[Qemu-devel] [PATCH V10 08/17] block: move qmp_query_block() and bdrv_query_info() to block/qapi.c

2013-03-22 Thread Wenchao Xia
This is a code move patch, except in qmp_query_block bdrv_next(bs) is used instead of direct traverse of global array 'bdrv_states'. This patch also fix code style error reported by check script. Signed-off-by: Wenchao Xia --- block.c | 76

Re: [Qemu-devel] [PATCH V10 08/17] block: move qmp_query_block() and bdrv_query_info() to block/qapi.c

2013-03-29 Thread Eric Blake
On 03/22/2013 08:19 AM, Wenchao Xia wrote: > This is a code move patch, except in qmp_query_block bdrv_next(bs) > is used instead of direct traverse of global array 'bdrv_states'. Mixing code motion and a code change isn't always the best, but at least you were honest about it. I don't know how

Re: [Qemu-devel] [PATCH V10 08/17] block: move qmp_query_block() and bdrv_query_info() to block/qapi.c

2013-03-30 Thread Wenchao Xia
于 2013-3-30 4:10, Eric Blake 写道: On 03/22/2013 08:19 AM, Wenchao Xia wrote: This is a code move patch, except in qmp_query_block bdrv_next(bs) is used instead of direct traverse of global array 'bdrv_states'. Mixing code motion and a code change isn't always the best, but at least you were