Re: [Qemu-devel] [PATCH V11 1/5] throttle: Add a new throttling API implementing continuous leaky bucket.

2013-09-02 Thread Benoît Canet
> However, I think this is not what the code is doing right now, isn't it? Hi Paolo, I changed the code so it trigger only if the request size is bigger than op_size. Best regards Benoît

Re: [Qemu-devel] [PATCH V11 1/5] throttle: Add a new throttling API implementing continuous leaky bucket.

2013-09-02 Thread Paolo Bonzini
Il 02/09/2013 12:16, Benoît Canet ha scritto: >> If op_size is non-zero, iops limits are merely a fixed proportion of bps >> > limits, which means the lower set of the two is applied and the higher >> > skipped. >> > I understand the amazon uses op_size like accounting for big IO requests, >> > b

Re: [Qemu-devel] [PATCH V11 1/5] throttle: Add a new throttling API implementing continuous leaky bucket.

2013-09-02 Thread Benoît Canet
> If op_size is non-zero, iops limits are merely a fixed proportion of bps > limits, which means the lower set of the two is applied and the higher > skipped. > I understand the amazon uses op_size like accounting for big IO requests, but > we don't do it condionally on io size or anything here, s

Re: [Qemu-devel] [PATCH V11 1/5] throttle: Add a new throttling API implementing continuous leaky bucket.

2013-09-01 Thread Fam Zheng
On Sun, 09/01 18:39, Benoît Canet wrote: > Implement the continuous leaky bucket algorithm devised on IRC as a separate > module. > > Signed-off-by: Benoit Canet > --- > include/qemu/throttle.h | 103 > util/Makefile.objs |1 + > util/throttle.c | 396 > +

[Qemu-devel] [PATCH V11 1/5] throttle: Add a new throttling API implementing continuous leaky bucket.

2013-09-01 Thread Benoît Canet
Implement the continuous leaky bucket algorithm devised on IRC as a separate module. Signed-off-by: Benoit Canet --- include/qemu/throttle.h | 103 util/Makefile.objs |1 + util/throttle.c | 396 +++ 3 files changed, 500