Re: [Qemu-devel] [PATCH V14 02/10] build: use check-clean in root Makefile

2013-01-24 Thread Wenchao Xia
于 2013-1-24 16:27, Paolo Bonzini 写道: Il 24/01/2013 02:51, Wenchao Xia ha scritto: You can put the dependency in tests/Makefile. Paolo tests/Makefile would not be included, so it will directly fail. Actually I use this variable as a bridge between root Makefile and sub Makefile which would

Re: [Qemu-devel] [PATCH V14 02/10] build: use check-clean in root Makefile

2013-01-24 Thread Paolo Bonzini
Il 24/01/2013 02:51, Wenchao Xia ha scritto: >> >> You can put the dependency in tests/Makefile. >> >> Paolo >> > tests/Makefile would not be included, so it will directly fail. > Actually I use this variable as a bridge between root Makefile and > sub Makefile which would be included by root Mak

Re: [Qemu-devel] [PATCH V14 02/10] build: use check-clean in root Makefile

2013-01-23 Thread Wenchao Xia
于 2013-1-23 19:43, Paolo Bonzini 写道: Il 23/01/2013 12:35, Wenchao Xia ha scritto: Just use "clean: check-clean" and squash this with patch 1. Paolo That have a problem if test/Makefile is not included, which will happen if make distclean is called once, then error will be shown if make

Re: [Qemu-devel] [PATCH V14 02/10] build: use check-clean in root Makefile

2013-01-23 Thread Paolo Bonzini
Il 23/01/2013 12:35, Wenchao Xia ha scritto: >>> >> >> Just use "clean: check-clean" and squash this with patch 1. >> >> Paolo >> > That have a problem if test/Makefile is not included, which will > happen if make distclean is called once, then error will be shown > if make clean called again. It

Re: [Qemu-devel] [PATCH V14 02/10] build: use check-clean in root Makefile

2013-01-23 Thread Wenchao Xia
于 2013-1-23 19:32, Paolo Bonzini 写道: Il 23/01/2013 12:17, Wenchao Xia ha scritto: Now root Makefile simply calls the command and do not care the details of it any more. $SUBDIR_CLEAN_RULES is used for the case that a sub-dir's Makefile is included by root Makefile, in which case 'clean' in su

Re: [Qemu-devel] [PATCH V14 02/10] build: use check-clean in root Makefile

2013-01-23 Thread Paolo Bonzini
Il 23/01/2013 12:17, Wenchao Xia ha scritto: > Now root Makefile simply calls the command and do not care > the details of it any more. $SUBDIR_CLEAN_RULES is used for the > case that a sub-dir's Makefile is included by root Makefile, > in which case 'clean' in subdir's Makefile will cause confic

[Qemu-devel] [PATCH V14 02/10] build: use check-clean in root Makefile

2013-01-23 Thread Wenchao Xia
Now root Makefile simply calls the command and do not care the details of it any more. $SUBDIR_CLEAN_RULES is used for the case that a sub-dir's Makefile is included by root Makefile, in which case 'clean' in subdir's Makefile will cause confict. So If sub-dir's Makefile want to be cleaned, it sh