Re: [Qemu-devel] [PATCH V18 4/6] rename qcow2-cache.c to block-cache.c

2013-04-22 Thread Dong Xu Wang
On 2013/4/18 16:54, Stefan Hajnoczi wrote: On Wed, Apr 10, 2013 at 04:11:51PM +0800, Dong Xu Wang wrote: This patch does two things: 1. Rename and move qcow2-cache to block-cache. 2. Add a type enum to parameterize BLKDEBUG_EVENT() for L2, refcount, and bitmaps. It's hard to review #2 since

Re: [Qemu-devel] [PATCH V18 4/6] rename qcow2-cache.c to block-cache.c

2013-04-18 Thread Stefan Hajnoczi
On Wed, Apr 10, 2013 at 04:11:51PM +0800, Dong Xu Wang wrote: This patch does two things: 1. Rename and move qcow2-cache to block-cache. 2. Add a type enum to parameterize BLKDEBUG_EVENT() for L2, refcount, and bitmaps. It's hard to review #2 since all lines are changed in the diff by #1. In t

[Qemu-devel] [PATCH V18 4/6] rename qcow2-cache.c to block-cache.c

2013-04-10 Thread Dong Xu Wang
We will re-use qcow2-cache as block layer common cache code, so change its name and made some changes, define a struct named BlockTableType, pass BlockTableType and table size parameters to block cache initialization function. Signed-off-by: Dong Xu Wang --- v17-v18: 1) move struct to source file