Re: [Qemu-devel] [PATCH V18 5/6] add-cow file format core code.

2013-05-13 Thread Jeff Cody
On Wed, Apr 10, 2013 at 04:11:52PM +0800, Dong Xu Wang wrote: add-cow file format core code. It use block-cache.c as cache code. It lacks of snapshot_blkdev support. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- v17-v18: 1) use error_report, not fprintf. 2) remove version

Re: [Qemu-devel] [PATCH V18 5/6] add-cow file format core code.

2013-05-13 Thread Dong Xu Wang
On 2013/5/13 23:07, Jeff Cody wrote: On Wed, Apr 10, 2013 at 04:11:52PM +0800, Dong Xu Wang wrote: add-cow file format core code. It use block-cache.c as cache code. It lacks of snapshot_blkdev support. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- v17-v18: 1) use error_report,

Re: [Qemu-devel] [PATCH V18 5/6] add-cow file format core code.

2013-05-09 Thread Dong Xu Wang
On Thu, Apr 18, 2013 at 6:03 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Apr 10, 2013 at 04:11:52PM +0800, Dong Xu Wang wrote: +header.cluster_bits = ffs(cluster_size) - 1; +if (header.cluster_bits MIN_CLUSTER_BITS || +header.cluster_bits MAX_CLUSTER_BITS || +

Re: [Qemu-devel] [PATCH V18 5/6] add-cow file format core code.

2013-05-09 Thread Stefan Hajnoczi
On Thu, May 09, 2013 at 02:24:20PM +0800, Dong Xu Wang wrote: On Thu, Apr 18, 2013 at 6:03 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Apr 10, 2013 at 04:11:52PM +0800, Dong Xu Wang wrote: +static coroutine_fn int add_cow_co_flush(BlockDriverState *bs) +{ +BDRVAddCowState *s

Re: [Qemu-devel] [PATCH V18 5/6] add-cow file format core code.

2013-04-22 Thread Dong Xu Wang
On 2013/4/18 18:03, Stefan Hajnoczi wrote: On Wed, Apr 10, 2013 at 04:11:52PM +0800, Dong Xu Wang wrote: +header.cluster_bits = ffs(cluster_size) - 1; +if (header.cluster_bits MIN_CLUSTER_BITS || +header.cluster_bits MAX_CLUSTER_BITS || +(1 header.cluster_bits) !=

Re: [Qemu-devel] [PATCH V18 5/6] add-cow file format core code.

2013-04-18 Thread Stefan Hajnoczi
On Wed, Apr 10, 2013 at 04:11:52PM +0800, Dong Xu Wang wrote: +header.cluster_bits = ffs(cluster_size) - 1; +if (header.cluster_bits MIN_CLUSTER_BITS || +header.cluster_bits MAX_CLUSTER_BITS || +(1 header.cluster_bits) != cluster_size) { +error_report( +

[Qemu-devel] [PATCH V18 5/6] add-cow file format core code.

2013-04-10 Thread Dong Xu Wang
add-cow file format core code. It use block-cache.c as cache code. It lacks of snapshot_blkdev support. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- v17-v18: 1) use error_report, not fprintf. 2) remove version field from header. 3) header_size is MAX(cluster_size, 4096). 4)