Re: [Qemu-devel] [PATCH V19 1/7] Support for TPM command line options

2012-11-12 Thread Stefan Berger
On 11/08/2012 10:52 AM, Corey Bryant wrote: On 10/24/2012 03:06 PM, Stefan Berger wrote: On 09/27/2012 10:12 AM, Corey Bryant wrote: On 06/04/2012 03:37 PM, Stefan Berger wrote: +if (!QLIST_EMPTY(&tpm_backends)) { +error_report("Only one TPM is allowed.\n"); +return 1

Re: [Qemu-devel] [PATCH V19 1/7] Support for TPM command line options

2012-11-08 Thread Corey Bryant
On 10/24/2012 03:06 PM, Stefan Berger wrote: On 09/27/2012 10:12 AM, Corey Bryant wrote: On 06/04/2012 03:37 PM, Stefan Berger wrote: + +#ifdef CONFIG_TPM + +static const TPMDriverOps *bes[] = { I think bes[] would be more descriptive if it were named be_drivers[] or be_ops[]? Renamed

Re: [Qemu-devel] [PATCH V19 1/7] Support for TPM command line options

2012-10-24 Thread Stefan Berger
On 09/27/2012 10:12 AM, Corey Bryant wrote: On 06/04/2012 03:37 PM, Stefan Berger wrote: + +#ifdef CONFIG_TPM + +static const TPMDriverOps *bes[] = { I think bes[] would be more descriptive if it were named be_drivers[] or be_ops[]? Renamed to be_drivers. +if (!QLIST_EMPTY(&tpm_ba

Re: [Qemu-devel] [PATCH V19 1/7] Support for TPM command line options

2012-09-27 Thread Corey Bryant
On 06/04/2012 03:37 PM, Stefan Berger wrote: This patch adds support for TPM command line options. The command line options supported here are ./qemu-... -tpmdev passthrough,path=,id= -device tpm-tis,tpmdev= and ./qemu-... -tpmdev ? where the latter works similar to -soundhw ? a

[Qemu-devel] [PATCH V19 1/7] Support for TPM command line options

2012-06-04 Thread Stefan Berger
This patch adds support for TPM command line options. The command line options supported here are ./qemu-... -tpmdev passthrough,path=,id= -device tpm-tis,tpmdev= and ./qemu-... -tpmdev ? where the latter works similar to -soundhw ? and shows a list of available TPM backends (for exa