Re: [Qemu-devel] [PATCH V19 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-11-12 Thread Corey Bryant
On 11/12/2012 08:16 AM, Stefan Berger wrote: On 11/08/2012 10:39 AM, Corey Bryant wrote: Thanks for your responses. I have a few comments below. On 10/24/2012 02:46 PM, Stefan Berger wrote: On 09/27/2012 10:22 AM, Corey Bryant wrote: On 06/04/2012 03:37 PM, Stefan Berger wrote: +

Re: [Qemu-devel] [PATCH V19 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-11-12 Thread Stefan Berger
On 11/08/2012 10:39 AM, Corey Bryant wrote: Thanks for your responses. I have a few comments below. On 10/24/2012 02:46 PM, Stefan Berger wrote: On 09/27/2012 10:22 AM, Corey Bryant wrote: On 06/04/2012 03:37 PM, Stefan Berger wrote: +/* check for ongoing seize by a highe

Re: [Qemu-devel] [PATCH V19 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-11-08 Thread Corey Bryant
Thanks for your responses. I have a few comments below. On 10/24/2012 02:46 PM, Stefan Berger wrote: On 09/27/2012 10:22 AM, Corey Bryant wrote: On 06/04/2012 03:37 PM, Stefan Berger wrote: + +/* whether the STS interrupt is supported */ +/*#define RAISE_STS_IRQ */ Why is this commented o

Re: [Qemu-devel] [PATCH V19 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-10-24 Thread Stefan Berger
On 09/27/2012 10:22 AM, Corey Bryant wrote: On 06/04/2012 03:37 PM, Stefan Berger wrote: + +/* whether the STS interrupt is supported */ +/*#define RAISE_STS_IRQ */ Why is this commented out? Will activate it. +if ((tis->loc[locty].inte & TPM_TIS_INT_ENABLED) && +(tis->loc[lo

Re: [Qemu-devel] [PATCH V19 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-10-03 Thread Corey Bryant
I'm adding a few more comments spread throughout this series that I forgot to mention previously.. On 06/04/2012 03:37 PM, Stefan Berger wrote: This patch adds the main code of the TPM frontend driver, the TPM TIS interface, to Qemu. The code is largely based on the previous implementation for

Re: [Qemu-devel] [PATCH V19 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-09-27 Thread Corey Bryant
On 06/04/2012 03:37 PM, Stefan Berger wrote: This patch adds the main code of the TPM frontend driver, the TPM TIS interface, to Qemu. The code is largely based on the previous implementation for Xen but has been significantly extended to meet the standard's requirements, such as the support fo

[Qemu-devel] [PATCH V19 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-06-04 Thread Stefan Berger
This patch adds the main code of the TPM frontend driver, the TPM TIS interface, to Qemu. The code is largely based on the previous implementation for Xen but has been significantly extended to meet the standard's requirements, such as the support for changing of localities and all the functionalit