Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped

2010-08-26 Thread Paolo Bonzini
On 08/26/2010 02:57 PM, Luiz Capitulino wrote: I really don't know what to do 0.13. Probably the hard-coded timer is the best solution we have, but I'm wondering if it's going to cause problems in the near future, when we get proper asynchronous command support. Just make it a different command

Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped

2010-08-26 Thread Anthony Liguori
On 08/26/2010 03:14 AM, Daniel P. Berrange wrote: On Thu, Aug 26, 2010 at 10:05:44AM +0200, Paolo Bonzini wrote: On 08/26/2010 08:05 AM, Amit Shah wrote: This is what I have currently. It would need some timer handling in the save/load case as well, right? When loading you wo

Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped

2010-08-26 Thread Luiz Capitulino
On Thu, 26 Aug 2010 09:28:42 +0100 "Daniel P. Berrange" wrote: > On Thu, Aug 26, 2010 at 01:47:50PM +0530, Amit Shah wrote: > > On (Thu) Aug 26 2010 [10:05:44], Paolo Bonzini wrote: > > > On 08/26/2010 08:05 AM, Amit Shah wrote: > > > >This is what I have currently. It would need some timer handl

Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped

2010-08-26 Thread Daniel P. Berrange
On Thu, Aug 26, 2010 at 01:47:50PM +0530, Amit Shah wrote: > On (Thu) Aug 26 2010 [10:05:44], Paolo Bonzini wrote: > > On 08/26/2010 08:05 AM, Amit Shah wrote: > > >This is what I have currently. It would need some timer handling in > > >the save/load case as well, right? > > > > When loading you

Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped

2010-08-26 Thread Amit Shah
On (Thu) Aug 26 2010 [10:05:44], Paolo Bonzini wrote: > On 08/26/2010 08:05 AM, Amit Shah wrote: > >This is what I have currently. It would need some timer handling in > >the save/load case as well, right? > > When loading you won't have any pending "info balloon" command, so I > think the timer n

Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped

2010-08-26 Thread Paolo Bonzini
On 08/26/2010 10:17 AM, Amit Shah wrote: > > Also, 5 seconds for a stopped guest is actually a lot, That's the problem; it's policy. Where and how to specify it? For a crashed/oopsed guest even 10 seconds may be okay, as long as it's 0 for a stopped guest. We need both patches. Paolo

Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped

2010-08-26 Thread Daniel P. Berrange
On Thu, Aug 26, 2010 at 10:05:44AM +0200, Paolo Bonzini wrote: > On 08/26/2010 08:05 AM, Amit Shah wrote: > >This is what I have currently. It would need some timer handling in > >the save/load case as well, right? > > When loading you won't have any pending "info balloon" command, so I > think t

Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped

2010-08-26 Thread Paolo Bonzini
On 08/26/2010 08:05 AM, Amit Shah wrote: This is what I have currently. It would need some timer handling in the save/load case as well, right? When loading you won't have any pending "info balloon" command, so I think the timer need not be preserved across migration. Also, 5 seconds for a s

Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped

2010-08-25 Thread Amit Shah
On (Sun) Aug 22 2010 [16:54:06], Anthony Liguori wrote: > On 08/19/2010 07:48 PM, Amit Shah wrote: > >If the machine is stopped and 'info balloon' is invoked, the monitor > >process just hangs waiting for info from the guest. Return the most > >recent balloon data in that case. > > > >See https://b

Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped

2010-08-25 Thread Amit Shah
On (Sun) Aug 22 2010 [16:54:06], Anthony Liguori wrote: > On 08/19/2010 07:48 PM, Amit Shah wrote: > >If the machine is stopped and 'info balloon' is invoked, the monitor > >process just hangs waiting for info from the guest. Return the most > >recent balloon data in that case. > > > >See https://b

Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped

2010-08-23 Thread Daniel P. Berrange
On Sun, Aug 22, 2010 at 04:54:06PM -0500, Anthony Liguori wrote: > On 08/19/2010 07:48 PM, Amit Shah wrote: > >If the machine is stopped and 'info balloon' is invoked, the monitor > >process just hangs waiting for info from the guest. Return the most > >recent balloon data in that case. > > > >See

Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped

2010-08-22 Thread Anthony Liguori
On 08/19/2010 07:48 PM, Amit Shah wrote: If the machine is stopped and 'info balloon' is invoked, the monitor process just hangs waiting for info from the guest. Return the most recent balloon data in that case. See https://bugzilla.redhat.com/show_bug.cgi?id=623903 Reported-by: Signed-off-by:

Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped

2010-08-20 Thread Amit Shah
On (Fri) Aug 20 2010 [06:18:11], Amit Shah wrote: > If the machine is stopped and 'info balloon' is invoked, the monitor > process just hangs waiting for info from the guest. Return the most > recent balloon data in that case. > > See https://bugzilla.redhat.com/show_bug.cgi?id=623903 > > Reporte

[Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped

2010-08-19 Thread Amit Shah
If the machine is stopped and 'info balloon' is invoked, the monitor process just hangs waiting for info from the guest. Return the most recent balloon data in that case. See https://bugzilla.redhat.com/show_bug.cgi?id=623903 Reported-by: Signed-off-by: Amit Shah --- v2: simplify call to qemu_b