Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-26 Thread Paolo Bonzini
Il 24/06/2013 19:58, Stefan Weil ha scritto: hw/ppc/spapr_hcall.c:188:1: warning: control reaches end of non-void function [-Wreturn-type] hw/ppc/spapr_pci.c:454:1: warning: control reaches end of non-void function [-Wreturn-type] I think you could report this to mingw. GCC should handle if

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-24 Thread Paolo Bonzini
Il 22/06/2013 12:03, Stefan Weil ha scritto: Am 18.06.2013 12:13, schrieb Paolo Bonzini: Il 07/06/2013 14:17, Markus Armbruster ha scritto: diff --git a/util/iov.c b/util/iov.c index cc6e837..b91cfb9 100644 --- a/util/iov.c +++ b/util/iov.c @@ -146,7 +146,7 @@ ssize_t iov_send_recv(int

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-24 Thread Stefan Weil
Am 24.06.2013 16:44, schrieb Paolo Bonzini: Il 22/06/2013 12:03, Stefan Weil ha scritto: I get this warning, too, when I run a normal cross compilation with MinGW-w64: util/iov.c:190:33: warning: ‘orig_len’ may be used uninitialized in this function [-Wuninitialized] My build environment:

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-24 Thread Wenchao Xia
于 2013-6-24 22:44, Paolo Bonzini 写道: Il 22/06/2013 12:03, Stefan Weil ha scritto: Am 18.06.2013 12:13, schrieb Paolo Bonzini: Il 07/06/2013 14:17, Markus Armbruster ha scritto: diff --git a/util/iov.c b/util/iov.c index cc6e837..b91cfb9 100644 --- a/util/iov.c +++ b/util/iov.c @@ -146,7

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-22 Thread Stefan Weil
Am 18.06.2013 12:13, schrieb Paolo Bonzini: Il 07/06/2013 14:17, Markus Armbruster ha scritto: diff --git a/util/iov.c b/util/iov.c index cc6e837..b91cfb9 100644 --- a/util/iov.c +++ b/util/iov.c @@ -146,7 +146,7 @@ ssize_t iov_send_recv(int sockfd, struct iovec *iov, unsigned iov_cnt, {

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-19 Thread Wenchao Xia
于 2013-6-18 18:13, Paolo Bonzini 写道: Il 07/06/2013 14:17, Markus Armbruster ha scritto: diff --git a/util/iov.c b/util/iov.c index cc6e837..b91cfb9 100644 --- a/util/iov.c +++ b/util/iov.c @@ -146,7 +146,7 @@ ssize_t iov_send_recv(int sockfd, struct iovec *iov, unsigned iov_cnt, {

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-19 Thread Paolo Bonzini
Il 19/06/2013 08:27, Wenchao Xia ha scritto: gcc is too stupid to understand the control flow. The initialization shuts it up. Looks like most people's GCC is not that stupid, or I would have broken build for everyone, right? my gcc version: [xiawenc@RH63Wenchao ~]$ gcc -v Using

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-18 Thread Paolo Bonzini
Il 07/06/2013 14:17, Markus Armbruster ha scritto: diff --git a/util/iov.c b/util/iov.c index cc6e837..b91cfb9 100644 --- a/util/iov.c +++ b/util/iov.c @@ -146,7 +146,7 @@ ssize_t iov_send_recv(int sockfd, struct iovec *iov, unsigned iov_cnt, { ssize_t total = 0; ssize_t ret;

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-18 Thread Paolo Bonzini
Il 08/06/2013 04:04, Wenchao Xia ha scritto: I insist to remove compile warning since I want gcc check my code with strict rule. What is your version of GCC? Paolo

[Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-07 Thread Wenchao Xia
This patch simply remove variable may be used uninitialized warning. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- V2: Address Stefan and Peter's comments, use 0 in send_msg() instead of initialize mhHeader. libcacard/vscclient.c |3 +-- util/iov.c|2 +- 2 files

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-07 Thread Stefan Hajnoczi
On Fri, Jun 07, 2013 at 06:02:09PM +0800, Wenchao Xia wrote: This patch simply remove variable may be used uninitialized warning. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- V2: Address Stefan and Peter's comments, use 0 in send_msg() instead of initialize mhHeader.

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-07 Thread Markus Armbruster
Wenchao Xia xiaw...@linux.vnet.ibm.com writes: This patch simply remove variable may be used uninitialized warning. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- V2: Address Stefan and Peter's comments, use 0 in send_msg() instead of initialize mhHeader. libcacard/vscclient.c

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-07 Thread Wenchao Xia
I insist to remove compile warning since I want gcc check my code with strict rule. Wenchao Xia xiaw...@linux.vnet.ibm.com writes: This patch simply remove variable may be used uninitialized warning. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- V2: Address Stefan and Peter's