Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

2017-01-24 Thread Michael S. Tsirkin
On Tue, Jan 24, 2017 at 04:50:44PM +0100, Paolo Bonzini wrote: > > > On 24/01/2017 16:05, Michael S. Tsirkin wrote: > >> > >> So we have four cases: > >> > >> - assign with emulated irqfd + ISR > >> - assign with emulated irqfd > >> - assign with irqfd > >> - deassign > >> > >> Currently we

Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

2017-01-24 Thread Paolo Bonzini
On 24/01/2017 16:05, Michael S. Tsirkin wrote: >> >> So we have four cases: >> >> - assign with emulated irqfd + ISR >> - assign with emulated irqfd >> - assign with irqfd >> - deassign >> >> Currently we don't distinguish the first two, so (which I don't like) >> Shannon's patch ends up setting

Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

2017-01-24 Thread Michael S. Tsirkin
On Tue, Jan 24, 2017 at 04:00:55PM +0100, Paolo Bonzini wrote: > > > On 24/01/2017 15:44, Michael S. Tsirkin wrote: > > On Tue, Jan 24, 2017 at 10:25:00AM +0100, Paolo Bonzini wrote: > >> > >> > >> On 23/01/2017 18:04, Michael S. Tsirkin wrote: > For virtio-blk, my patch moved the setting

Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

2017-01-24 Thread Paolo Bonzini
On 24/01/2017 15:44, Michael S. Tsirkin wrote: > On Tue, Jan 24, 2017 at 10:25:00AM +0100, Paolo Bonzini wrote: >> >> >> On 23/01/2017 18:04, Michael S. Tsirkin wrote: For virtio-blk, my patch moved the setting of ISR from virtio_queue_guest_notifier_read to virtio_notify_irqfd. This

Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

2017-01-24 Thread Michael S. Tsirkin
On Tue, Jan 24, 2017 at 10:25:00AM +0100, Paolo Bonzini wrote: > > > On 23/01/2017 18:04, Michael S. Tsirkin wrote: > >> For virtio-blk, my patch moved the setting of ISR from > >> virtio_queue_guest_notifier_read to virtio_notify_irqfd. This is > >> because the irqfd emulation only needs to

Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

2017-01-24 Thread Paolo Bonzini
On 23/01/2017 18:04, Michael S. Tsirkin wrote: >> For virtio-blk, my patch moved the setting of ISR from >> virtio_queue_guest_notifier_read to virtio_notify_irqfd. This is >> because the irqfd emulation only needs to trigger the interrupt. >> Setting the ISR should have been done elsewhere. >>

Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

2017-01-23 Thread Michael S. Tsirkin
On Mon, Jan 23, 2017 at 05:46:47PM +0100, Paolo Bonzini wrote: > > > On 23/01/2017 17:07, Michael S. Tsirkin wrote: > > On Mon, Jan 23, 2017 at 08:55:04AM +0800, Shannon Zhao wrote: > >> From: Shannon Zhao > >> > >> For ARM virt machine, if we use virt-2.7 which will

Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

2017-01-23 Thread Paolo Bonzini
On 23/01/2017 17:07, Michael S. Tsirkin wrote: > On Mon, Jan 23, 2017 at 08:55:04AM +0800, Shannon Zhao wrote: >> From: Shannon Zhao >> >> For ARM virt machine, if we use virt-2.7 which will not create ITS node, >> the virtio-net can not recieve interrupts so it can't

Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

2017-01-23 Thread Michael S. Tsirkin
On Mon, Jan 23, 2017 at 08:55:04AM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > For ARM virt machine, if we use virt-2.7 which will not create ITS node, > the virtio-net can not recieve interrupts so it can't get ip address > through dhcp. > This fixes commit

[Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

2017-01-22 Thread Shannon Zhao
From: Shannon Zhao For ARM virt machine, if we use virt-2.7 which will not create ITS node, the virtio-net can not recieve interrupts so it can't get ip address through dhcp. This fixes commit 83d768b(virtio: set ISR on dataplane notifications). Signed-off-by: Shannon