Re: [Qemu-devel] [PATCH V2] virtio-net: unbreak any layout

2015-07-16 Thread Jason Wang
On 07/16/2015 03:29 PM, Michael S. Tsirkin wrote: > On Thu, Jul 16, 2015 at 02:49:48PM +0800, Jason Wang wrote: >> > >> > >> > On 07/16/2015 02:42 PM, Michael S. Tsirkin wrote: >>> > > On Wed, Jul 15, 2015 at 03:56:07PM +0800, Jason Wang wrote: > >> Commit 032a74a1c0fcdd5fd1c69e56126b4c857

Re: [Qemu-devel] [PATCH V2] virtio-net: unbreak any layout

2015-07-16 Thread Michael S. Tsirkin
On Thu, Jul 16, 2015 at 02:49:48PM +0800, Jason Wang wrote: > > > On 07/16/2015 02:42 PM, Michael S. Tsirkin wrote: > > On Wed, Jul 15, 2015 at 03:56:07PM +0800, Jason Wang wrote: > >> Commit 032a74a1c0fcdd5fd1c69e56126b4c857ee36611 > >> ("virtio-net: byteswap virtio-net header") breaks any layou

Re: [Qemu-devel] [PATCH V2] virtio-net: unbreak any layout

2015-07-15 Thread Jason Wang
On 07/16/2015 02:42 PM, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2015 at 03:56:07PM +0800, Jason Wang wrote: >> Commit 032a74a1c0fcdd5fd1c69e56126b4c857ee36611 >> ("virtio-net: byteswap virtio-net header") breaks any layout by >> requiring out_sg[0].iov_len >= n->guest_hdr_len. Fixing this by

Re: [Qemu-devel] [PATCH V2] virtio-net: unbreak any layout

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 03:56:07PM +0800, Jason Wang wrote: > Commit 032a74a1c0fcdd5fd1c69e56126b4c857ee36611 > ("virtio-net: byteswap virtio-net header") breaks any layout by > requiring out_sg[0].iov_len >= n->guest_hdr_len. Fixing this by > copying header to temporary buffer if swap is needed, a

Re: [Qemu-devel] [PATCH V2] virtio-net: unbreak any layout

2015-07-15 Thread Michael S. Tsirkin
On Thu, Jul 16, 2015 at 01:54:38PM +0800, Jason Wang wrote: > > > On 07/15/2015 07:23 PM, Michael S. Tsirkin wrote: > > On Wed, Jul 15, 2015 at 03:56:07PM +0800, Jason Wang wrote: > >> Commit 032a74a1c0fcdd5fd1c69e56126b4c857ee36611 > >> ("virtio-net: byteswap virtio-net header") breaks any layou

Re: [Qemu-devel] [PATCH V2] virtio-net: unbreak any layout

2015-07-15 Thread Jason Wang
On 07/15/2015 07:23 PM, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2015 at 03:56:07PM +0800, Jason Wang wrote: >> Commit 032a74a1c0fcdd5fd1c69e56126b4c857ee36611 >> ("virtio-net: byteswap virtio-net header") breaks any layout by >> requiring out_sg[0].iov_len >= n->guest_hdr_len. Fixing this by

Re: [Qemu-devel] [PATCH V2] virtio-net: unbreak any layout

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 03:56:07PM +0800, Jason Wang wrote: > Commit 032a74a1c0fcdd5fd1c69e56126b4c857ee36611 > ("virtio-net: byteswap virtio-net header") breaks any layout by > requiring out_sg[0].iov_len >= n->guest_hdr_len. Fixing this by > copying header to temporary buffer if swap is needed, a

Re: [Qemu-devel] [PATCH V2] virtio-net: unbreak any layout

2015-07-15 Thread Paolo Bonzini
On 15/07/2015 09:56, Jason Wang wrote: > Commit 032a74a1c0fcdd5fd1c69e56126b4c857ee36611 > ("virtio-net: byteswap virtio-net header") breaks any layout by > requiring out_sg[0].iov_len >= n->guest_hdr_len. Fixing this by > copying header to temporary buffer if swap is needed, and then use > this

[Qemu-devel] [PATCH V2] virtio-net: unbreak any layout

2015-07-15 Thread Jason Wang
Commit 032a74a1c0fcdd5fd1c69e56126b4c857ee36611 ("virtio-net: byteswap virtio-net header") breaks any layout by requiring out_sg[0].iov_len >= n->guest_hdr_len. Fixing this by copying header to temporary buffer if swap is needed, and then use this buffer as part of out_sg. Fixes 032a74a1c0fcdd5fd1