Re: [Qemu-devel] [PATCH V2 02/10] qemu-clk: allow to add a clock to a device

2017-02-07 Thread Frederic Konrad
On 02/07/2017 10:31 AM, Cédric Le Goater wrote: > On 02/07/2017 10:22 AM, Frederic Konrad wrote: >>> I see how these routines are used in patch 10/10. But if we were >>> open coding device CRF_APB, I don't think we would need them at >>> all and it would make the code a little simple IMHO. >> What

Re: [Qemu-devel] [PATCH V2 02/10] qemu-clk: allow to add a clock to a device

2017-02-07 Thread Cédric Le Goater
On 02/07/2017 10:22 AM, Frederic Konrad wrote: >> I see how these routines are used in patch 10/10. But if we were >> open coding device CRF_APB, I don't think we would need them at >> all and it would make the code a little simple IMHO. > What do you mean by open coding? I mean to externalize

Re: [Qemu-devel] [PATCH V2 02/10] qemu-clk: allow to add a clock to a device

2017-02-07 Thread Frederic Konrad
On 02/06/2017 03:20 PM, Cédric Le Goater wrote: > On 01/26/2017 10:47 AM, fred.kon...@greensocs.com wrote: >> From: KONRAD Frederic >> >> This allows to add a clock to a DeviceState. >> Contrary to gpios, the clock pins are not contained in the DeviceState but >> with

Re: [Qemu-devel] [PATCH V2 02/10] qemu-clk: allow to add a clock to a device

2017-02-06 Thread Cédric Le Goater
On 01/26/2017 10:47 AM, fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > This allows to add a clock to a DeviceState. > Contrary to gpios, the clock pins are not contained in the DeviceState but > with the child property so they can appears in the qom-tree.

[Qemu-devel] [PATCH V2 02/10] qemu-clk: allow to add a clock to a device

2017-01-26 Thread fred . konrad
From: KONRAD Frederic This allows to add a clock to a DeviceState. Contrary to gpios, the clock pins are not contained in the DeviceState but with the child property so they can appears in the qom-tree. Signed-off-by: KONRAD Frederic V1 ->