Re: [Qemu-devel] [PATCH V2 03/11] block: add snapshot and image info query function

2013-01-10 Thread Wenchao Xia
于 2013-1-10 21:36, Eric Blake 写道: On 01/09/2013 10:43 PM, Wenchao Xia wrote: v2: Generally, the v2 information should go... Do you know how to put change log under "---" in "git commit"? I found it inconvenient to edit every ".patch" file, so added the log directly in commit message.

Re: [Qemu-devel] [PATCH V2 03/11] block: add snapshot and image info query function

2013-01-10 Thread Eric Blake
On 01/09/2013 10:43 PM, Wenchao Xia wrote: >>> >>> v2: >> >> Generally, the v2 information should go... >> > Do you know how to put change log under "---" in "git commit"? > I found it inconvenient to edit every ".patch" file, so added the > log directly in commit message. Sure - manually put a

Re: [Qemu-devel] [PATCH V2 03/11] block: add snapshot and image info query function

2013-01-09 Thread Wenchao Xia
于 2013-1-9 23:56, Eric Blake 写道: On 01/08/2013 10:12 PM, Wenchao Xia wrote: This patch added function bdrv_query_image_info() and bdrv_query_snapshot_infolist(), which will return info in qmp object format. The implemetion code are mostly copied from collect_image_info() s/implemetion/impl

Re: [Qemu-devel] [PATCH V2 03/11] block: add snapshot and image info query function

2013-01-09 Thread Eric Blake
On 01/08/2013 10:12 PM, Wenchao Xia wrote: > This patch added function bdrv_query_image_info() and > bdrv_query_snapshot_infolist(), which will return info in qmp object > format. The implemetion code are mostly copied from collect_image_info() s/implemetion/implementation/ > and collect_snaps

[Qemu-devel] [PATCH V2 03/11] block: add snapshot and image info query function

2013-01-08 Thread Wenchao Xia
This patch added function bdrv_query_image_info() and bdrv_query_snapshot_infolist(), which will return info in qmp object format. The implemetion code are mostly copied from collect_image_info() and collect_snapshot() in qemu-img.c. To help filter out snapshot info not needed, a call back func