Re: [Qemu-devel] [PATCH V2 1/5] block: package preparation code in qmp_transaction()

2013-04-16 Thread Eric Blake
On 04/13/2013 05:11 AM, Wenchao Xia wrote: > The code before really committing is moved into a function. Most > code are simply moved from qmp_transaction()i, except fail handling s/i,/,/ > label is changed from "delete_and_fail" to "fail". Other code such > as input parsing is not touched, to

Re: [Qemu-devel] [PATCH V2 1/5] block: package preparation code in qmp_transaction()

2013-04-16 Thread Kevin Wolf
Am 13.04.2013 um 13:11 hat Wenchao Xia geschrieben: > The code before really committing is moved into a function. Most This line seems to be indented accidentally? > code are simply moved from qmp_transaction()i, except fail handling > label is changed from "delete_and_fail" to "fail". Other co

[Qemu-devel] [PATCH V2 1/5] block: package preparation code in qmp_transaction()

2013-04-13 Thread Wenchao Xia
The code before really committing is moved into a function. Most code are simply moved from qmp_transaction()i, except fail handling label is changed from "delete_and_fail" to "fail". Other code such as input parsing is not touched, to make it easier in review. Signed-off-by: Wenchao Xia --- b