Re: [Qemu-devel] [PATCH V2 2/5] block: move snapshot code in block.c to block/snapshot.c

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 04:47:13PM +0800, Wenchao Xia wrote: > -int bdrv_is_snapshot(BlockDriverState *bs) > -{ > -return !!(bs->open_flags & BDRV_O_SNAPSHOT); > -} No need to respin, but this function has nothing to do with the other functions. This function is about -drive snapshot=on, the

[Qemu-devel] [PATCH V2 2/5] block: move snapshot code in block.c to block/snapshot.c

2013-05-23 Thread Wenchao Xia
All snapshot related code, except bdrv_snapshot_dump(), is moved to block/snapshot.c. bdrv_snapshot_dump() will be moved to another file later. It also fixes small code style errors reported by check script. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake --- block.c | 105