Re: [Qemu-devel] [PATCH V2 2/5] virtio-blk: advertise scsi only when scsi is set

On 07/15/2015 03:57 PM, Paolo Bonzini wrote: > > On 15/07/2015 07:29, Jason Wang wrote: >> Cc: Stefan Hajnoczi >> Cc: Kevin Wolf >> Cc: qemu-bl...@nongnu.org >> Signed-off-by: Jason Wang >> --- >> hw/block/virtio-blk.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --g

Re: [Qemu-devel] [PATCH V2 2/5] virtio-blk: advertise scsi only when scsi is set

On 15/07/2015 10:31, Jason Wang wrote: > > This must only be done for newer machine types only, or you change guest > > ABI for scsi=off. Effectively you have to split it in two properties, > > "scsi" and "always_set_f_scsi". > > And always_set_f_scsi is true only for legacy machine types? s/le

Re: [Qemu-devel] [PATCH V2 2/5] virtio-blk: advertise scsi only when scsi is set

On 15/07/2015 07:29, Jason Wang wrote: > Cc: Stefan Hajnoczi > Cc: Kevin Wolf > Cc: qemu-bl...@nongnu.org > Signed-off-by: Jason Wang > --- > hw/block/virtio-blk.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c > inde

[Qemu-devel] [PATCH V2 2/5] virtio-blk: advertise scsi only when scsi is set

Cc: Stefan Hajnoczi Cc: Kevin Wolf Cc: qemu-bl...@nongnu.org Signed-off-by: Jason Wang --- hw/block/virtio-blk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 4c27974..761d763 100644 --- a/hw/block/virtio-blk.c +++ b/h