On Thu, Mar 22, 2012 at 2:17 PM, Paolo Bonzini wrote:
> Il 22/03/2012 15:15, Benoît Canet ha scritto:
>>
>> I added this flag after seeing the following code in in bdrv_open_common.
>>
>> /*
>> * Clear flags that are internal to the block layer before opening the
>> * image.
>>
Il 22/03/2012 15:15, Benoît Canet ha scritto:
>
> I added this flag after seeing the following code in in bdrv_open_common.
>
> /*
> * Clear flags that are internal to the block layer before opening the
> * image.
> */
> open_flags = flags & ~(BDRV_O_SNAPSHOT | BDRV_O_NO_BA
>It's not clear to me why we need to introduce this field to stash
>flags values. bs->open_flags already has this information.
>Originally this was introduced in 06d9260ffa9 ("qcow2: implement
>bdrv_invalidate_cache (v2)") for qcow2. I wonder if that field is
>necessary when we already have bs->
On Wed, Mar 21, 2012 at 3:52 PM, Benoît Canet wrote:
> The QED image is reopened to flush metadata and check consistency.
>
> Signed-off-by: Benoit Canet
> ---
> block/qed.c | 15 +++
> block/qed.h | 1 +
> 2 files changed, 16 insertions(+), 0 deletions(-)
>
> diff --git a/block
The QED image is reopened to flush metadata and check consistency.
Signed-off-by: Benoit Canet
---
block/qed.c | 15 +++
block/qed.h |1 +
2 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/block/qed.c b/block/qed.c
index a041d31..c47272c 100644
--- a/block/qed.c
+