Re: [Qemu-devel] [PATCH V2 4/8] virtio-pci: fix 1.0 virtqueue migration

2015-09-10 Thread Michael S. Tsirkin
On Tue, Sep 08, 2015 at 03:27:59PM +0800, Jason Wang wrote: > > > On 09/07/2015 04:21 PM, Cornelia Huck wrote: > > On Mon, 7 Sep 2015 15:39:59 +0800 > > Jason Wang wrote: > > > >> > On 09/02/2015 07:06 PM, Cornelia Huck wrote: > >>> > > On Wed, 2 Sep 2015 11:25:21 +0800 > >>> > > Jason Wang wr

Re: [Qemu-devel] [PATCH V2 4/8] virtio-pci: fix 1.0 virtqueue migration

2015-09-08 Thread Jason Wang
On 09/07/2015 04:21 PM, Cornelia Huck wrote: > On Mon, 7 Sep 2015 15:39:59 +0800 > Jason Wang wrote: > >> > On 09/02/2015 07:06 PM, Cornelia Huck wrote: >>> > > On Wed, 2 Sep 2015 11:25:21 +0800 >>> > > Jason Wang wrote: > >> +static int get_extra_state(QEMUFile *f, void *pv, size_t size)

Re: [Qemu-devel] [PATCH V2 4/8] virtio-pci: fix 1.0 virtqueue migration

2015-09-07 Thread Cornelia Huck
On Mon, 7 Sep 2015 15:39:59 +0800 Jason Wang wrote: > On 09/02/2015 07:06 PM, Cornelia Huck wrote: > > On Wed, 2 Sep 2015 11:25:21 +0800 > > Jason Wang wrote: > >> +static int get_extra_state(QEMUFile *f, void *pv, size_t size) > >> +{ > >> +VirtIODevice *vdev = pv; > >> +BusState *qbu

Re: [Qemu-devel] [PATCH V2 4/8] virtio-pci: fix 1.0 virtqueue migration

2015-09-07 Thread Jason Wang
On 09/02/2015 07:06 PM, Cornelia Huck wrote: > On Wed, 2 Sep 2015 11:25:21 +0800 > Jason Wang wrote: > >> We don't migrate the followings fields for virtio-pci: >> >> uint32_t dfselect; >> uint32_t gfselect; >> uint32_t guest_features[2]; >> struct { >> uint16_t num; >> bool enabled; >>

Re: [Qemu-devel] [PATCH V2 4/8] virtio-pci: fix 1.0 virtqueue migration

2015-09-02 Thread Cornelia Huck
On Wed, 2 Sep 2015 11:25:21 +0800 Jason Wang wrote: > We don't migrate the followings fields for virtio-pci: > > uint32_t dfselect; > uint32_t gfselect; > uint32_t guest_features[2]; > struct { > uint16_t num; > bool enabled; > uint32_t desc[2]; > uint32_t avail[2]; > uint32

[Qemu-devel] [PATCH V2 4/8] virtio-pci: fix 1.0 virtqueue migration

2015-09-01 Thread Jason Wang
We don't migrate the followings fields for virtio-pci: uint32_t dfselect; uint32_t gfselect; uint32_t guest_features[2]; struct { uint16_t num; bool enabled; uint32_t desc[2]; uint32_t avail[2]; uint32_t used[2]; } vqs[VIRTIO_QUEUE_MAX]; This will confuse driver if migrating d