Re: [Qemu-devel] [PATCH V2 5/5] block: make all steps in qmp_transaction() as callback

2013-04-16 Thread Kevin Wolf
Am 13.04.2013 um 13:11 hat Wenchao Xia geschrieben: Now qmp_transaction() can be extended with other operation, external snapshot or backing chain creation, is just one case it. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- blockdev.c | 68

Re: [Qemu-devel] [PATCH V2 5/5] block: make all steps in qmp_transaction() as callback

2013-04-16 Thread Eric Blake
On 04/13/2013 05:11 AM, Wenchao Xia wrote: Now qmp_transaction() can be extended with other operation, external snapshot or backing chain creation, is just one case it. This read a bit awkwardly. Might I suggest: block: use callbacks in qmp_transaction() Make it easier to add other

Re: [Qemu-devel] [PATCH V2 5/5] block: make all steps in qmp_transaction() as callback

2013-04-16 Thread Wenchao Xia
于 2013-4-16 21:52, Kevin Wolf 写道: Am 13.04.2013 um 13:11 hat Wenchao Xia geschrieben: Now qmp_transaction() can be extended with other operation, external snapshot or backing chain creation, is just one case it. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- blockdev.c | 68

[Qemu-devel] [PATCH V2 5/5] block: make all steps in qmp_transaction() as callback

2013-04-13 Thread Wenchao Xia
Now qmp_transaction() can be extended with other operation, external snapshot or backing chain creation, is just one case it. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- blockdev.c | 68 +++ 1 files changed, 58