Re: [Qemu-devel] [PATCH V26 20/32] qed.c: replace QEMUOptionParameter with QemuOpts

2014-05-06 Thread Stefan Hajnoczi
On Tue, Apr 29, 2014 at 05:10:44PM +0800, Chunyan Liu wrote: > One extra change is to define QED_DEFAULT_CLUSTER_SIZE = 65536 instead > of 64 * 1024; because: > according to existing create_options, "cluster size" has default value = > QED_DEFAULT_CLUSTER_SIZE, after switching to create_opts, this

Re: [Qemu-devel] [PATCH V26 20/32] qed.c: replace QEMUOptionParameter with QemuOpts

2014-05-05 Thread Eric Blake
On 04/29/2014 03:10 AM, Chunyan Liu wrote: > One extra change is to define QED_DEFAULT_CLUSTER_SIZE = 65536 instead > of 64 * 1024; because: > according to existing create_options, "cluster size" has default value = > QED_DEFAULT_CLUSTER_SIZE, after switching to create_opts, this has to be > string

[Qemu-devel] [PATCH V26 20/32] qed.c: replace QEMUOptionParameter with QemuOpts

2014-04-29 Thread Chunyan Liu
One extra change is to define QED_DEFAULT_CLUSTER_SIZE = 65536 instead of 64 * 1024; because: according to existing create_options, "cluster size" has default value = QED_DEFAULT_CLUSTER_SIZE, after switching to create_opts, this has to be stringized and set to .def_value_str. That is, .def_value

[Qemu-devel] [PATCH V26 20/32] qed.c: replace QEMUOptionParameter with QemuOpts

2014-04-29 Thread Chunyan Liu
One extra change is to define QED_DEFAULT_CLUSTER_SIZE = 65536 instead of 64 * 1024; because: according to existing create_options, "cluster size" has default value = QED_DEFAULT_CLUSTER_SIZE, after switching to create_opts, this has to be stringized and set to .def_value_str. That is, .def_value