Re: [Qemu-devel] [PATCH V3 05/10] net/net.c: Add vnet header length to SocketReadState

2017-05-09 Thread Jason Wang
On 2017年05月09日 14:59, Zhang Chen wrote: On 05/09/2017 01:36 PM, Jason Wang wrote: On 2017年05月09日 12:03, Zhang Chen wrote: On 05/09/2017 10:40 AM, Jason Wang wrote: On 2017年05月08日 11:47, Zhang Chen wrote: On 05/03/2017 06:42 PM, Jason Wang wrote: On 2017年05月03日 11:43, Zhang Chen

Re: [Qemu-devel] [PATCH V3 05/10] net/net.c: Add vnet header length to SocketReadState

2017-05-09 Thread Zhang Chen
On 05/09/2017 01:36 PM, Jason Wang wrote: On 2017年05月09日 12:03, Zhang Chen wrote: On 05/09/2017 10:40 AM, Jason Wang wrote: On 2017年05月08日 11:47, Zhang Chen wrote: On 05/03/2017 06:42 PM, Jason Wang wrote: On 2017年05月03日 11:43, Zhang Chen wrote: On 05/02/2017 12:53 PM, Jason Wa

Re: [Qemu-devel] [PATCH V3 05/10] net/net.c: Add vnet header length to SocketReadState

2017-05-08 Thread Jason Wang
On 2017年05月09日 12:03, Zhang Chen wrote: On 05/09/2017 10:40 AM, Jason Wang wrote: On 2017年05月08日 11:47, Zhang Chen wrote: On 05/03/2017 06:42 PM, Jason Wang wrote: On 2017年05月03日 11:43, Zhang Chen wrote: On 05/02/2017 12:53 PM, Jason Wang wrote: On 2017年04月28日 17:47, Zhang Chen

Re: [Qemu-devel] [PATCH V3 05/10] net/net.c: Add vnet header length to SocketReadState

2017-05-08 Thread Zhang Chen
On 05/09/2017 10:40 AM, Jason Wang wrote: On 2017年05月08日 11:47, Zhang Chen wrote: On 05/03/2017 06:42 PM, Jason Wang wrote: On 2017年05月03日 11:43, Zhang Chen wrote: On 05/02/2017 12:53 PM, Jason Wang wrote: On 2017年04月28日 17:47, Zhang Chen wrote: Address Jason Wang's comments add v

Re: [Qemu-devel] [PATCH V3 05/10] net/net.c: Add vnet header length to SocketReadState

2017-05-08 Thread Jason Wang
On 2017年05月08日 11:47, Zhang Chen wrote: On 05/03/2017 06:42 PM, Jason Wang wrote: On 2017年05月03日 11:43, Zhang Chen wrote: On 05/02/2017 12:53 PM, Jason Wang wrote: On 2017年04月28日 17:47, Zhang Chen wrote: Address Jason Wang's comments add vnet header length to SocketReadState. Inst

Re: [Qemu-devel] [PATCH V3 05/10] net/net.c: Add vnet header length to SocketReadState

2017-05-07 Thread Zhang Chen
On 05/03/2017 06:42 PM, Jason Wang wrote: On 2017年05月03日 11:43, Zhang Chen wrote: On 05/02/2017 12:53 PM, Jason Wang wrote: On 2017年04月28日 17:47, Zhang Chen wrote: Address Jason Wang's comments add vnet header length to SocketReadState. Instead of saying this, you can add "Suggested-

Re: [Qemu-devel] [PATCH V3 05/10] net/net.c: Add vnet header length to SocketReadState

2017-05-03 Thread Jason Wang
On 2017年05月03日 11:43, Zhang Chen wrote: On 05/02/2017 12:53 PM, Jason Wang wrote: On 2017年04月28日 17:47, Zhang Chen wrote: Address Jason Wang's comments add vnet header length to SocketReadState. Instead of saying this, you can add "Suggested-by: Jason Wang " above your sign-off. OK.

Re: [Qemu-devel] [PATCH V3 05/10] net/net.c: Add vnet header length to SocketReadState

2017-05-02 Thread Zhang Chen
On 05/02/2017 12:53 PM, Jason Wang wrote: On 2017年04月28日 17:47, Zhang Chen wrote: Address Jason Wang's comments add vnet header length to SocketReadState. Instead of saying this, you can add "Suggested-by: Jason Wang " above your sign-off. OK. So we change net_fill_rstate() to read

Re: [Qemu-devel] [PATCH V3 05/10] net/net.c: Add vnet header length to SocketReadState

2017-05-01 Thread Jason Wang
On 2017年04月28日 17:47, Zhang Chen wrote: Address Jason Wang's comments add vnet header length to SocketReadState. Instead of saying this, you can add "Suggested-by: Jason Wang " above your sign-off. So we change net_fill_rstate() to read struct {int size; int vnet_hdr_len; const uint8_t b

[Qemu-devel] [PATCH V3 05/10] net/net.c: Add vnet header length to SocketReadState

2017-04-28 Thread Zhang Chen
Address Jason Wang's comments add vnet header length to SocketReadState. So we change net_fill_rstate() to read struct {int size; int vnet_hdr_len; const uint8_t buf[];}. Signed-off-by: Zhang Chen --- include/net/net.h | 4 +++- net/net.c | 24 ++-- 2 files changed,