Re: [Qemu-devel] [PATCH V3 1/2] Resend - Add code to track call origin for msr assignment.

2012-11-26 Thread Gleb Natapov
On Mon, Nov 26, 2012 at 07:42:28PM +, Auld, Will wrote: > Gleb, Marcelo, > > Sorry Gleb, I did not see comments from you but I have now found them. In > doing so I also found one form Marcelo that I missed. > > What I believe is now outstanding to be addressed are: > >From Gleb: > - You've

Re: [Qemu-devel] [PATCH V3 1/2] Resend - Add code to track call origin for msr assignment.

2012-11-26 Thread Auld, Will
Gleb, Marcelo, Sorry Gleb, I did not see comments from you but I have now found them. In doing so I also found one form Marcelo that I missed. What I believe is now outstanding to be addressed are: >From Gleb: - You've changed function pointer signature here, but emulator_set_msr() remained th

Re: [Qemu-devel] [PATCH V3 1/2] Resend - Add code to track call origin for msr assignment.

2012-11-26 Thread Gleb Natapov
Comments are still not addressed. On Mon, Nov 26, 2012 at 10:40:51AM -0800, Will Auld wrote: > In order to track who initiated the call (host or guest) to modify an msr > value I have changed function call parameters along the call path. The > specific change is to add a struct pointer parameter t

[Qemu-devel] [PATCH V3 1/2] Resend - Add code to track call origin for msr assignment.

2012-11-26 Thread Will Auld
In order to track who initiated the call (host or guest) to modify an msr value I have changed function call parameters along the call path. The specific change is to add a struct pointer parameter that points to (index, data, caller) information rather than having this information passed as indivi