Re: [Qemu-devel] [PATCH V3 2/2] sdhci: Change debug prints to compile unconditionally

2015-09-07 Thread Sai Pavan Boddu
> -Original Message- > From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Monday, September 07, 2015 10:52 PM > To: Sai Pavan Boddu; qemu-triv...@nongnu.org > Cc: qemu-devel@nongnu.org Developers; Eric Blake; Peter Maydell; Alistair > Francis; Edgar Iglesias; Sai Pavan Bo

Re: [Qemu-devel] [PATCH V3 2/2] sdhci: Change debug prints to compile unconditionally

2015-09-07 Thread Peter Crosthwaite
On Sun, Sep 6, 2015 at 11:45 PM, Sai Pavan Boddu wrote: > Conditionaly compilation hides few type mismatch warnings, fix it to "conditional" > compile unconditioinal. > "unconditionally" > Signed-off-by: Sai Pavan Boddu > Suggested-by: Eric Blake Otherwise: Reviewed-by: Peter Crosthwaite

Re: [Qemu-devel] [PATCH V3 2/2] sdhci: Change debug prints to compile unconditionally

2015-09-07 Thread Markus Armbruster
@gmail.com; >> qemu-devel@nongnu.org; Edgar Iglesias >> Subject: Re: [Qemu-devel] [PATCH V3 2/2] sdhci: Change debug prints to >> compile unconditionally >> >> Sai Pavan Boddu writes: >> >> >> -Original Message- >> >> From: Mark

Re: [Qemu-devel] [PATCH V3 2/2] sdhci: Change debug prints to compile unconditionally

2015-09-07 Thread Sai Pavan Boddu
5 PM > >> To: Sai Pavan Boddu > >> Cc: qemu-devel@nongnu.org; crosthwaitepe...@gmail.com; > >> ebl...@redhat.com; peter.mayd...@linaro.org; Sai Pavan Boddu; Edgar > >> Iglesias; Alistair Francis > >> Subject: Re: [Qemu-devel] [PATCH V3 2/2] sdhci: Change

Re: [Qemu-devel] [PATCH V3 2/2] sdhci: Change debug prints to compile unconditionally

2015-09-07 Thread Markus Armbruster
.mayd...@linaro.org; Sai Pavan Boddu; Edgar >> Iglesias; Alistair Francis >> Subject: Re: [Qemu-devel] [PATCH V3 2/2] sdhci: Change debug prints to >> compile unconditionally >> >> Sai Pavan Boddu writes: >> >> > Conditionaly compilation hides few ty

Re: [Qemu-devel] [PATCH V3 2/2] sdhci: Change debug prints to compile unconditionally

2015-09-07 Thread Sai Pavan Boddu
t; Iglesias; Alistair Francis > Subject: Re: [Qemu-devel] [PATCH V3 2/2] sdhci: Change debug prints to > compile unconditionally > > Sai Pavan Boddu writes: > > > Conditionaly compilation hides few type mismatch warnings, fix it to > > compile unconditioinal. > >

Re: [Qemu-devel] [PATCH V3 2/2] sdhci: Change debug prints to compile unconditionally

2015-09-07 Thread Markus Armbruster
Sai Pavan Boddu writes: > Conditionaly compilation hides few type mismatch warnings, fix it to > compile unconditioinal. > > Signed-off-by: Sai Pavan Boddu > Suggested-by: Eric Blake No objection to this patch, but have you considered tracepoints? See docs/tracing.txt.

[Qemu-devel] [PATCH V3 2/2] sdhci: Change debug prints to compile unconditionally

2015-09-06 Thread Sai Pavan Boddu
Conditionaly compilation hides few type mismatch warnings, fix it to compile unconditioinal. Signed-off-by: Sai Pavan Boddu Suggested-by: Eric Blake --- hw/sd/sdhci.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd