Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Thu, 23 Jul 2015 11:37:44 +0200 Paolo Bonzini wrote: > On 23/07/2015 11:07, Cornelia Huck wrote: > > > Paolo said this specific feature has been deprecated for years, no > > > one should be using it, so we dropped it from spec. > > > > Nothing wrong with that. But "it's deprecated" does not me

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On 23/07/2015 11:07, Cornelia Huck wrote: > > Paolo said this specific feature has been deprecated for years, no > > one should be using it, so we dropped it from spec. > > Nothing wrong with that. But "it's deprecated" does not mean "nobody's > using it", I fear. The question is: Should qemu acc

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, 22 Jul 2015 19:34:31 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jul 22, 2015 at 06:11:16PM +0200, Cornelia Huck wrote: > > On Wed, 22 Jul 2015 17:53:47 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jul 22, 2015 at 12:55:22PM +0200, Cornelia Huck wrote: > > > > On Wed, 22 Jul

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On 22/07/2015 18:15, Michael S. Tsirkin wrote: > > No, the feature is not desirable in the future. There is no reason > > really not to use virtio-scsi passthrough instead, since virtio-scsi has > > been out for about 3 years now and is stable. > > Given the amount of work we are spending handli

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, Jul 22, 2015 at 06:11:16PM +0200, Cornelia Huck wrote: > On Wed, 22 Jul 2015 17:53:47 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 22, 2015 at 12:55:22PM +0200, Cornelia Huck wrote: > > > On Wed, 22 Jul 2015 13:44:14 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Wed,

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, Jul 22, 2015 at 01:40:25PM +0200, Paolo Bonzini wrote: > > > On 22/07/2015 12:19, Michael S. Tsirkin wrote: > > > > SCSI passthrough was no longer supported in virtio 1.0, so this patch > > > > fail the get_features() when both 1.0 and scsi is set. And also only > > > > advertise VIRTIO_B

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, 22 Jul 2015 17:53:47 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jul 22, 2015 at 12:55:22PM +0200, Cornelia Huck wrote: > > On Wed, 22 Jul 2015 13:44:14 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jul 22, 2015 at 12:38:40PM +0200, Cornelia Huck wrote: > > > > On Wed, 22 Jul

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, Jul 22, 2015 at 01:53:14PM +0200, Paolo Bonzini wrote: > > > On 22/07/2015 13:46, Daniel P. Berrange wrote: > > IIUC, the SCSI passthrough feature for virtio-blk is enabled by > > setting the 'scsi=on' property on the virtio-blk device, which is > > exposed by libvirt with XML: > > > >

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, Jul 22, 2015 at 12:55:22PM +0200, Cornelia Huck wrote: > On Wed, 22 Jul 2015 13:44:14 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 22, 2015 at 12:38:40PM +0200, Cornelia Huck wrote: > > > On Wed, 22 Jul 2015 13:32:17 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Wed,

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On 22/07/2015 13:46, Daniel P. Berrange wrote: > IIUC, the SCSI passthrough feature for virtio-blk is enabled by > setting the 'scsi=on' property on the virtio-blk device, which is > exposed by libvirt with XML: > > > > > > > > (For use with virtio-scsi you'd just

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, Jul 22, 2015 at 01:40:25PM +0200, Paolo Bonzini wrote: > > > On 22/07/2015 12:19, Michael S. Tsirkin wrote: > > > > SCSI passthrough was no longer supported in virtio 1.0, so this patch > > > > fail the get_features() when both 1.0 and scsi is set. And also only > > > > advertise VIRTIO_B

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On 22/07/2015 12:19, Michael S. Tsirkin wrote: > > > SCSI passthrough was no longer supported in virtio 1.0, so this patch > > > fail the get_features() when both 1.0 and scsi is set. And also only > > > advertise VIRTIO_BLK_F_SCSI for legacy virtio-blk device. > > > > Why is SCSI passthrough su

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, 22 Jul 2015 13:44:14 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jul 22, 2015 at 12:38:40PM +0200, Cornelia Huck wrote: > > On Wed, 22 Jul 2015 13:32:17 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jul 22, 2015 at 12:25:31PM +0200, Cornelia Huck wrote: > > > > On Wed, 22 Jul

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, Jul 22, 2015 at 12:38:40PM +0200, Cornelia Huck wrote: > On Wed, 22 Jul 2015 13:32:17 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 22, 2015 at 12:25:31PM +0200, Cornelia Huck wrote: > > > On Wed, 22 Jul 2015 12:21:32 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Wed,

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, 22 Jul 2015 13:32:17 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jul 22, 2015 at 12:25:31PM +0200, Cornelia Huck wrote: > > On Wed, 22 Jul 2015 12:21:32 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jul 22, 2015 at 10:58:43AM +0200, Cornelia Huck wrote: > > > > On Wed, 22 Jul

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, Jul 22, 2015 at 12:25:31PM +0200, Cornelia Huck wrote: > On Wed, 22 Jul 2015 12:21:32 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 22, 2015 at 10:58:43AM +0200, Cornelia Huck wrote: > > > On Wed, 22 Jul 2015 13:59:51 +0800 > > > Jason Wang wrote: > > > > > > > SCSI passthrough

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, 22 Jul 2015 12:21:32 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jul 22, 2015 at 10:58:43AM +0200, Cornelia Huck wrote: > > On Wed, 22 Jul 2015 13:59:51 +0800 > > Jason Wang wrote: > > > > > SCSI passthrough was no longer supported in virtio 1.0, so this patch > > > fail the get_feature

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, 22 Jul 2015 17:35:07 +0800 Jason Wang wrote: > > > On 07/22/2015 04:58 PM, Cornelia Huck wrote: > > On Wed, 22 Jul 2015 13:59:51 +0800 > > Jason Wang wrote: > > > >> SCSI passthrough was no longer supported in virtio 1.0, so this patch > >> fail the get_features() when both 1.0 and scs

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, Jul 22, 2015 at 10:31:45AM +0100, Daniel P. Berrange wrote: > On Wed, Jul 22, 2015 at 01:59:51PM +0800, Jason Wang wrote: > > SCSI passthrough was no longer supported in virtio 1.0, so this patch > > fail the get_features() when both 1.0 and scsi is set. And also only > > advertise VIRTIO_B

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, Jul 22, 2015 at 05:52:29PM +0800, Jason Wang wrote: > > > On 07/22/2015 05:25 PM, Michael S. Tsirkin wrote: > > On Wed, Jul 22, 2015 at 01:59:51PM +0800, Jason Wang wrote: > >> SCSI passthrough was no longer supported in virtio 1.0, so this patch > >> fail the get_features() when both 1.0

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, Jul 22, 2015 at 01:12:45PM +0300, Michael S. Tsirkin wrote: > On Wed, Jul 22, 2015 at 05:52:29PM +0800, Jason Wang wrote: > > > > > > On 07/22/2015 05:25 PM, Michael S. Tsirkin wrote: > > > On Wed, Jul 22, 2015 at 01:59:51PM +0800, Jason Wang wrote: > > >> SCSI passthrough was no longer s

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On 07/22/2015 05:25 PM, Michael S. Tsirkin wrote: > On Wed, Jul 22, 2015 at 01:59:51PM +0800, Jason Wang wrote: >> SCSI passthrough was no longer supported in virtio 1.0, so this patch >> fail the get_features() when both 1.0 and scsi is set. And also only >> advertise VIRTIO_BLK_F_SCSI for legac

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On 07/22/2015 05:31 PM, Daniel P. Berrange wrote: > On Wed, Jul 22, 2015 at 01:59:51PM +0800, Jason Wang wrote: >> SCSI passthrough was no longer supported in virtio 1.0, so this patch >> fail the get_features() when both 1.0 and scsi is set. And also only >> advertise VIRTIO_BLK_F_SCSI for legac

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On 07/22/2015 04:58 PM, Cornelia Huck wrote: > On Wed, 22 Jul 2015 13:59:51 +0800 > Jason Wang wrote: > >> SCSI passthrough was no longer supported in virtio 1.0, so this patch >> fail the get_features() when both 1.0 and scsi is set. And also only >> advertise VIRTIO_BLK_F_SCSI for legacy virti

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, Jul 22, 2015 at 01:59:51PM +0800, Jason Wang wrote: > SCSI passthrough was no longer supported in virtio 1.0, so this patch > fail the get_features() when both 1.0 and scsi is set. And also only > advertise VIRTIO_BLK_F_SCSI for legacy virtio-blk device. Why is SCSI passthrough support not

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, Jul 22, 2015 at 01:59:51PM +0800, Jason Wang wrote: > SCSI passthrough was no longer supported in virtio 1.0, so this patch > fail the get_features() when both 1.0 and scsi is set. And also only > advertise VIRTIO_BLK_F_SCSI for legacy virtio-blk device. > > Signed-off-by: Jason Wang > --

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, Jul 22, 2015 at 10:58:43AM +0200, Cornelia Huck wrote: > On Wed, 22 Jul 2015 13:59:51 +0800 > Jason Wang wrote: > > > SCSI passthrough was no longer supported in virtio 1.0, so this patch > > fail the get_features() when both 1.0 and scsi is set. And also only > > advertise VIRTIO_BLK_F_S

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

On Wed, 22 Jul 2015 13:59:51 +0800 Jason Wang wrote: > SCSI passthrough was no longer supported in virtio 1.0, so this patch > fail the get_features() when both 1.0 and scsi is set. And also only > advertise VIRTIO_BLK_F_SCSI for legacy virtio-blk device. > > Signed-off-by: Jason Wang > --- >

[Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

SCSI passthrough was no longer supported in virtio 1.0, so this patch fail the get_features() when both 1.0 and scsi is set. And also only advertise VIRTIO_BLK_F_SCSI for legacy virtio-blk device. Signed-off-by: Jason Wang --- hw/block/virtio-blk.c | 9 - 1 file changed, 8 insertions(+),