Re: [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output

2013-05-27 Thread Luiz Capitulino
On Sat, 25 May 2013 11:09:45 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: bdrv_snapshot_dump() and bdrv_image_info_dump() do not dump to a buffer now, some internal buffers are still used for format control, which have no chance to be truncated. As a result, these two functions have no

Re: [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output

2013-05-27 Thread Kevin Wolf
Am 27.05.2013 um 17:02 hat Luiz Capitulino geschrieben: On Sat, 25 May 2013 11:09:45 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: bdrv_snapshot_dump() and bdrv_image_info_dump() do not dump to a buffer now, some internal buffers are still used for format control, which have no

Re: [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output

2013-05-27 Thread Luiz Capitulino
On Mon, 27 May 2013 17:40:59 +0200 Kevin Wolf kw...@redhat.com wrote: Am 27.05.2013 um 17:02 hat Luiz Capitulino geschrieben: On Sat, 25 May 2013 11:09:45 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: bdrv_snapshot_dump() and bdrv_image_info_dump() do not dump to a buffer

Re: [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output

2013-05-27 Thread Wenchao Xia
于 2013-5-27 23:40, Kevin Wolf 写道: Am 27.05.2013 um 17:02 hat Luiz Capitulino geschrieben: On Sat, 25 May 2013 11:09:45 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: bdrv_snapshot_dump() and bdrv_image_info_dump() do not dump to a buffer now, some internal buffers are still used for

Re: [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output

2013-05-25 Thread Eric Blake
On 05/24/2013 09:09 PM, Wenchao Xia wrote: bdrv_snapshot_dump() and bdrv_image_info_dump() do not dump to a buffer now, some internal buffers are still used for format control, which have no chance to be truncated. As a result, these two functions have no more issue of truncation, and they can

[Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output

2013-05-24 Thread Wenchao Xia
bdrv_snapshot_dump() and bdrv_image_info_dump() do not dump to a buffer now, some internal buffers are still used for format control, which have no chance to be truncated. As a result, these two functions have no more issue of truncation, and they can be used by both qemu and qemu-img with correct