Re: [Qemu-devel] [PATCH V3 6/9] qmp: add interface blockdev-snapshot-delete-internal-sync

2013-07-04 Thread Stefan Hajnoczi
On Thu, Jun 27, 2013 at 10:41:45AM +0800, Wenchao Xia wrote: > diff --git a/blockdev.c b/blockdev.c > index ce89f83..35fffd6 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -790,6 +790,67 @@ void qmp_blockdev_snapshot_internal_sync(const char > *device, > &snapshot, errp)

[Qemu-devel] [PATCH V3 6/9] qmp: add interface blockdev-snapshot-delete-internal-sync

2013-06-25 Thread Wenchao Xia
This interface use id and name as optional parameters, to handle the case that one image contain multiple snapshots with same name which may be '', but with different id. Adding parameter id is for historical compatiability reason, and that case is not possible in qemu's new interface for internal