Re: [Qemu-devel] [PATCH V4 09/12] hw/sd.c: convert SD state to QOM object

2012-07-31 Thread Igor Mitsyanko
On 07/31/2012 08:17 PM, Peter Maydell wrote: On 31 July 2012 16:29, Markus Armbruster wrote: Igor Mitsyanko writes: QEMU requires all objects derived from TYPE_DEVICE to be connected to some bus, if no bus was specified in new object class description, QEMU practically assumes this object to

Re: [Qemu-devel] [PATCH V4 09/12] hw/sd.c: convert SD state to QOM object

2012-07-31 Thread Peter Maydell
On 31 July 2012 16:29, Markus Armbruster wrote: > Igor Mitsyanko writes: >> QEMU requires all objects derived from TYPE_DEVICE to be connected to >> some bus, if no bus was specified in new object class description, >> QEMU practically assumes this object to be a sysbus device and >> connects it

Re: [Qemu-devel] [PATCH V4 09/12] hw/sd.c: convert SD state to QOM object

2012-07-31 Thread Markus Armbruster
Igor Mitsyanko writes: > On 07/31/2012 01:45 PM, Markus Armbruster wrote: >> Igor Mitsyanko writes: >> >>> A straightforward conversion of SD card implementation to a proper QEMU >>> object. >>> Wrapper functions were introduced for SDClass methods in order to avoid SD >>> card >>> users modif

Re: [Qemu-devel] [PATCH V4 09/12] hw/sd.c: convert SD state to QOM object

2012-07-31 Thread Igor Mitsyanko
On 07/31/2012 01:45 PM, Markus Armbruster wrote: Igor Mitsyanko writes: A straightforward conversion of SD card implementation to a proper QEMU object. Wrapper functions were introduced for SDClass methods in order to avoid SD card users modification. Because of this, name change for several f

Re: [Qemu-devel] [PATCH V4 09/12] hw/sd.c: convert SD state to QOM object

2012-07-31 Thread Peter Maydell
On 31 July 2012 10:45, Markus Armbruster wrote: > Igor Mitsyanko writes: >> @@ -1510,7 +1508,7 @@ void sd_write_data(SDState *sd, uint8_t value) >> return; >> >> if (sd->state != sd_receivingdata_state) { >> -fprintf(stderr, "sd_write_data: not in Receiving-Data state\n"); >

Re: [Qemu-devel] [PATCH V4 09/12] hw/sd.c: convert SD state to QOM object

2012-07-31 Thread Markus Armbruster
Igor Mitsyanko writes: > A straightforward conversion of SD card implementation to a proper QEMU > object. > Wrapper functions were introduced for SDClass methods in order to avoid SD > card > users modification. Because of this, name change for several functions in > hw/sd.c > was required. >

[Qemu-devel] [PATCH V4 09/12] hw/sd.c: convert SD state to QOM object

2012-07-27 Thread Igor Mitsyanko
A straightforward conversion of SD card implementation to a proper QEMU object. Wrapper functions were introduced for SDClass methods in order to avoid SD card users modification. Because of this, name change for several functions in hw/sd.c was required. Signed-off-by: Igor Mitsyanko --- hw/sd