Re: [Qemu-devel] [PATCH V4 1/2] Add code to track call origin for msr assignment.

2012-11-27 Thread Gleb Natapov
On Tue, Nov 27, 2012 at 06:19:21PM +, Auld, Will wrote: > Gleb, > > This last change to emulator_set_msr() was wrong as you point out. I will > change it back to what it was in V3 with the exception of fixing the bool > that Marcelo pointed out. > > However, the change of: > > struct kvm_

Re: [Qemu-devel] [PATCH V4 1/2] Add code to track call origin for msr assignment.

2012-11-27 Thread Auld, Will
Gleb, This last change to emulator_set_msr() was wrong as you point out. I will change it back to what it was in V3 with the exception of fixing the bool that Marcelo pointed out. However, the change of: struct kvm_x86_ops {... int (*set_msr)(struct kvm_vcpu *vcpu, struct msr_data *ms

Re: [Qemu-devel] [PATCH V4 1/2] Add code to track call origin for msr assignment.

2012-11-26 Thread Gleb Natapov
On Mon, Nov 26, 2012 at 05:35:07PM -0800, Will Auld wrote: > In order to track who initiated the call (host or guest) to modify an msr > value I have changed function call parameters along the call path. The > specific change is to add a struct pointer parameter that points to (index, > data, calle

[Qemu-devel] [PATCH V4 1/2] Add code to track call origin for msr assignment.

2012-11-26 Thread Will Auld
In order to track who initiated the call (host or guest) to modify an msr value I have changed function call parameters along the call path. The specific change is to add a struct pointer parameter that points to (index, data, caller) information rather than having this information passed as indivi