Re: [Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-22 Thread Stefan Hajnoczi
On Fri, Jan 19, 2018 at 10:37:22AM -0300, Philippe Mathieu-Daudé wrote: > On 01/19/2018 05:51 AM, Pavel Pisa wrote: > > On Tuesday 16 of January 2018 01:12:09 Philippe Mathieu-Daudé wrote: > >> On 01/15/2018 06:29 PM, Pavel Pisa wrote: > > But if the second format is preferred then I update the

Re: [Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-19 Thread Daniel P. Berrange
On Mon, Jan 15, 2018 at 09:12:09PM -0300, Philippe Mathieu-Daudé wrote: > On 01/15/2018 06:29 PM, Pavel Pisa wrote: > >>> +/* open socket */ > >>> +s = socket(PF_CAN, SOCK_RAW, CAN_RAW); > >> > >> I never used it, but I think QEMU uses his socket API: "qemu/sockets.h" > > > > The

Re: [Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-19 Thread Philippe Mathieu-Daudé
On 01/19/2018 05:51 AM, Pavel Pisa wrote: > Hello Philippe, > > On Tuesday 16 of January 2018 01:12:09 Philippe Mathieu-Daudé wrote: >> On 01/15/2018 06:29 PM, Pavel Pisa wrote: >>> Hello Philippe, >>> >>> thanks for review. >>> >>> I have updated patch series in can-pci branch in >>> >>>

Re: [Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-19 Thread Philippe Mathieu-Daudé
On 01/19/2018 09:57 AM, Philippe Mathieu-Daudé wrote: > Cc'ing Paolo and Marc-André, the "Character device backends" maintainers. > > On 01/14/2018 05:14 PM, p...@cmp.felk.cvut.cz wrote: >> From: Pavel Pisa >> >> Connection to the real host CAN bus network through >>

Re: [Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-19 Thread Philippe Mathieu-Daudé
Cc'ing Paolo and Marc-André, the "Character device backends" maintainers. On 01/14/2018 05:14 PM, p...@cmp.felk.cvut.cz wrote: > From: Pavel Pisa > > Connection to the real host CAN bus network through > SocketCAN network interface is available only for Linux > host

Re: [Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-19 Thread Pavel Pisa
Hello Philippe, On Tuesday 16 of January 2018 01:12:09 Philippe Mathieu-Daudé wrote: > On 01/15/2018 06:29 PM, Pavel Pisa wrote: > > Hello Philippe, > > > > thanks for review. > > > > I have updated patch series in can-pci branch in > > > > https://gitlab.fel.cvut.cz/canbus/qemu-canbus > > > >

Re: [Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-15 Thread Philippe Mathieu-Daudé
On 01/15/2018 06:29 PM, Pavel Pisa wrote: > Hello Philippe, > > thanks for review. > > I have updated patch series in can-pci branch in > > https://gitlab.fel.cvut.cz/canbus/qemu-canbus > > I would wait some day if there is some remark > from other developers and socket ones especially.

Re: [Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-15 Thread Pavel Pisa
Hello Philippe, thanks for review. I have updated patch series in can-pci branch in https://gitlab.fel.cvut.cz/canbus/qemu-canbus I would wait some day if there is some remark from other developers and socket ones especially. On Monday 15 of January 2018 03:55:00 Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-14 Thread Philippe Mathieu-Daudé
Hi Pavel, I'm CC'ing the QEMU Sockets maintainer to ask them a quick review of the socket part. On 01/14/2018 05:14 PM, p...@cmp.felk.cvut.cz wrote: > From: Pavel Pisa > > Connection to the real host CAN bus network through > SocketCAN network interface is available only

[Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-14 Thread pisa
From: Pavel Pisa Connection to the real host CAN bus network through SocketCAN network interface is available only for Linux host system. Mechanism is generic, support for another CAN API and operating systems can be implemented in future. Signed-off-by: Pavel Pisa