On Wed, 11 Dec 2013 11:52:28 +0800
Fam Zheng wrote:
> On 2013年12月10日 23:16, Luiz Capitulino wrote:
> > On Tue, 10 Dec 2013 15:25:07 +0100
> > Kevin Wolf wrote:
> >
> >> My objection to your approach is strong because Benoît already sent an
> >> alternative which I believe is less worse because w
On 2013年12月10日 23:16, Luiz Capitulino wrote:
On Tue, 10 Dec 2013 15:25:07 +0100
Kevin Wolf wrote:
My objection to your approach is strong because Benoît already sent an
alternative which I believe is less worse because with it, arguments
actually mean what their names tell instead of having ad
On 12/10/2013 08:16 AM, Luiz Capitulino wrote:
> On Tue, 10 Dec 2013 15:25:07 +0100
> Kevin Wolf wrote:
>
>> My objection to your approach is strong because Benoît already sent an
>> alternative which I believe is less worse because with it, arguments
>> actually mean what their names tell instea
Am 10.12.2013 um 16:16 hat Luiz Capitulino geschrieben:
> On Tue, 10 Dec 2013 15:25:07 +0100
> Kevin Wolf wrote:
>
> > My objection to your approach is strong because Benoît already sent an
> > alternative which I believe is less worse because with it, arguments
> > actually mean what their names
On Tue, 10 Dec 2013 15:25:07 +0100
Kevin Wolf wrote:
> My objection to your approach is strong because Benoît already sent an
> alternative which I believe is less worse because with it, arguments
> actually mean what their names tell instead of having additional bools
> for "oh, and I said A, bu
Am 10.12.2013 um 15:06 hat Luiz Capitulino geschrieben:
> On Tue, 10 Dec 2013 10:57:50 +0100
> Kevin Wolf wrote:
>
> > Am 09.12.2013 um 17:41 hat Luiz Capitulino geschrieben:
> > > On Mon, 9 Dec 2013 17:23:09 +0100
> > > Kevin Wolf wrote:
> > >
> > > > > > I'm leaning slightly towards the appro
On Tue, 10 Dec 2013 10:57:50 +0100
Kevin Wolf wrote:
> Am 09.12.2013 um 17:41 hat Luiz Capitulino geschrieben:
> > On Mon, 9 Dec 2013 17:23:09 +0100
> > Kevin Wolf wrote:
> >
> > > > > I'm leaning slightly towards the approach that Benoît took, if only
> > > > > for
> > > > > the naming aspect
Am 09.12.2013 um 17:41 hat Luiz Capitulino geschrieben:
> On Mon, 9 Dec 2013 17:23:09 +0100
> Kevin Wolf wrote:
>
> > > > I'm leaning slightly towards the approach that Benoît took, if only for
> > > > the naming aspect (that is, I also thought of the idea of a bool flag,
> > > > but didn't sugge
Le Monday 09 Dec 2013 à 12:03:26 (-0500), Luiz Capitulino a écrit :
> On Mon, 9 Dec 2013 17:48:50 +0100
> Benoît Canet wrote:
>
> > Le Monday 09 Dec 2013 à 11:41:09 (-0500), Luiz Capitulino a écrit :
> > > On Mon, 9 Dec 2013 17:23:09 +0100
> > > Kevin Wolf wrote:
> > >
> > > > > > I'm leaning s
On Mon, 9 Dec 2013 17:48:50 +0100
Benoît Canet wrote:
> Le Monday 09 Dec 2013 à 11:41:09 (-0500), Luiz Capitulino a écrit :
> > On Mon, 9 Dec 2013 17:23:09 +0100
> > Kevin Wolf wrote:
> >
> > > > > I'm leaning slightly towards the approach that Benoît took, if only
> > > > > for
> > > > > the
Le Monday 09 Dec 2013 à 11:41:09 (-0500), Luiz Capitulino a écrit :
> On Mon, 9 Dec 2013 17:23:09 +0100
> Kevin Wolf wrote:
>
> > > > I'm leaning slightly towards the approach that Benoît took, if only for
> > > > the naming aspect (that is, I also thought of the idea of a bool flag,
> > > > but
On Mon, 9 Dec 2013 17:23:09 +0100
Kevin Wolf wrote:
> > > I'm leaning slightly towards the approach that Benoît took, if only for
> > > the naming aspect (that is, I also thought of the idea of a bool flag,
> > > but didn't suggest it because I didn't like the implications on the
> > > naming).
Am 06.12.2013 um 17:52 hat Luiz Capitulino geschrieben:
> On Fri, 06 Dec 2013 08:24:33 -0700
> Eric Blake wrote:
>
> > On 12/06/2013 07:27 AM, Luiz Capitulino wrote:
> > > On Thu, 5 Dec 2013 18:15:00 +0100
> > > Benoît Canet wrote:
> >
> > >> -{ 'command': 'block_passwd', 'data': {'device': 's
Le Friday 06 Dec 2013 à 11:52:15 (-0500), Luiz Capitulino a écrit :
> On Fri, 06 Dec 2013 08:24:33 -0700
> Eric Blake wrote:
>
> > On 12/06/2013 07:27 AM, Luiz Capitulino wrote:
> > > On Thu, 5 Dec 2013 18:15:00 +0100
> > > Benoît Canet wrote:
> >
> > >> -{ 'command': 'block_passwd', 'data': {
On Fri, 06 Dec 2013 08:24:33 -0700
Eric Blake wrote:
> On 12/06/2013 07:27 AM, Luiz Capitulino wrote:
> > On Thu, 5 Dec 2013 18:15:00 +0100
> > Benoît Canet wrote:
>
> >> -{ 'command': 'block_passwd', 'data': {'device': 'str', 'password': 'str'}
> >> }
> >> +{ 'command': 'block_passwd', 'data
On 12/06/2013 07:27 AM, Luiz Capitulino wrote:
> On Thu, 5 Dec 2013 18:15:00 +0100
> Benoît Canet wrote:
>> -{ 'command': 'block_passwd', 'data': {'device': 'str', 'password': 'str'} }
>> +{ 'command': 'block_passwd', 'data': {'*device': 'str',
>> + '*node-na
On Thu, 5 Dec 2013 18:15:00 +0100
Benoît Canet wrote:
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1675,7 +1675,11 @@
> # determine which ones are encrypted, set the passwords with this command,
> and
> # then start the guest with the @cont command.
> #
> -# @device: the name of
Signed-off-by: Benoit Canet
---
block.c | 32
blockdev.c| 13 +
hmp.c | 2 +-
include/block/block.h | 3 +++
qapi-schema.json | 9 +++--
qmp-commands.hx | 3 ++-
6 files changed, 54 insertion
18 matches
Mail list logo
