Re: [Qemu-devel] [PATCH V6 1/3] Implement sync modes for drive-backup.

2013-07-25 Thread Kevin Wolf
Am 25.07.2013 um 00:01 hat Ian Main geschrieben: On Wed, Jul 24, 2013 at 02:32:53PM -0600, Eric Blake wrote: On 07/24/2013 04:55 AM, Kevin Wolf wrote: Unconditionally overriding format for NEW_IMAGE_MODE_EXISTING is definitely wrong. It's the user's choice which COW format to use for

Re: [Qemu-devel] [PATCH V6 1/3] Implement sync modes for drive-backup.

2013-07-25 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 24/07/2013 22:32, Eric Blake ha scritto: On 07/24/2013 04:55 AM, Kevin Wolf wrote: Unconditionally overriding format for NEW_IMAGE_MODE_EXISTING is definitely wrong. It's the user's choice which COW format to use for the backup image. There's

Re: [Qemu-devel] [PATCH V6 1/3] Implement sync modes for drive-backup.

2013-07-25 Thread Eric Blake
On 07/25/2013 08:36 AM, Paolo Bonzini wrote: Furthermore, I'm proposing that for 1.6, we should make the format argument mandatory for drive-backup. We made it optional for drive-mirror, to allow for probing, but there have been CVEs in the past due to probing of a raw file gone wrong. We

Re: [Qemu-devel] [PATCH V6 1/3] Implement sync modes for drive-backup.

2013-07-25 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 25/07/2013 18:57, Eric Blake ha scritto: On 07/25/2013 08:36 AM, Paolo Bonzini wrote: Furthermore, I'm proposing that for 1.6, we should make the format argument mandatory for drive-backup. We made it optional for drive-mirror, to allow for

Re: [Qemu-devel] [PATCH V6 1/3] Implement sync modes for drive-backup.

2013-07-24 Thread Kevin Wolf
Am 23.07.2013 um 00:09 hat Ian Main geschrieben: This patch adds sync-modes to the drive-backup interface and implements the FULL, NONE and TOP modes of synchronization. FULL performs as before copying the entire contents of the drive while preserving the point-in-time using CoW. NONE only

Re: [Qemu-devel] [PATCH V6 1/3] Implement sync modes for drive-backup.

2013-07-24 Thread Ian Main
On Wed, Jul 24, 2013 at 12:55:43PM +0200, Kevin Wolf wrote: Am 23.07.2013 um 00:09 hat Ian Main geschrieben: This patch adds sync-modes to the drive-backup interface and implements the FULL, NONE and TOP modes of synchronization. FULL performs as before copying the entire contents of the

Re: [Qemu-devel] [PATCH V6 1/3] Implement sync modes for drive-backup.

2013-07-24 Thread Eric Blake
On 07/24/2013 04:55 AM, Kevin Wolf wrote: Unconditionally overriding format for NEW_IMAGE_MODE_EXISTING is definitely wrong. It's the user's choice which COW format to use for the backup image. There's no reason why it has to be the same format as the image that is being backed up. Before,

Re: [Qemu-devel] [PATCH V6 1/3] Implement sync modes for drive-backup.

2013-07-24 Thread Ian Main
On Wed, Jul 24, 2013 at 02:32:53PM -0600, Eric Blake wrote: On 07/24/2013 04:55 AM, Kevin Wolf wrote: Unconditionally overriding format for NEW_IMAGE_MODE_EXISTING is definitely wrong. It's the user's choice which COW format to use for the backup image. There's no reason why it has to be

[Qemu-devel] [PATCH V6 1/3] Implement sync modes for drive-backup.

2013-07-22 Thread Ian Main
This patch adds sync-modes to the drive-backup interface and implements the FULL, NONE and TOP modes of synchronization. FULL performs as before copying the entire contents of the drive while preserving the point-in-time using CoW. NONE only copies new writes to the target drive. TOP copies