On 06/17/2014 03:21 AM, Paolo Bonzini wrote:
> Il 13/06/2014 23:27, Eric Blake ha scritto:
>>> > +# @RTC_CHANGE
>>> > +#
>>> > +# Emitted when the guest changes the RTC time.
>>> > +#
>>> > +# @offset: offset between base RTC clock (as specified by -rtc
>>> base), and
>>> > +# new RTC cloc
Il 13/06/2014 23:27, Eric Blake ha scritto:
> +# @RTC_CHANGE
> +#
> +# Emitted when the guest changes the RTC time.
> +#
> +# @offset: offset between base RTC clock (as specified by -rtc base), and
> +# new RTC clock value
> +#
> +# Since: 2.1
0.14.0
0.13.0 :)
Il 15/06/2014 02:38, Wenchao Xia ha scritto:
Once again, all callers of qapi_event_send_rtc_change() are passing a
NULL errp to silently ignore errors; and I just audited that no errors
happen anyways.
Fixing it.
No, please don't. I prefer the way you did it in v6.
Paolo
Il 13/06/2014 23:27, Eric Blake ha scritto:
>> visit_start_struct(v, NULL, "", "RTC_CHANGE", 0, &local_err);
>> if (local_err) {
>> goto clean;
>> }
Hmm, qmp_output_start_struct() never sets errp.
>>
>> visit_type_int(v, &offset, "offset", &local_err);
>> if (local_
δΊ 2014/6/14 5:27, Eric Blake ει:
On 06/05/2014 06:22 AM, Wenchao Xia wrote:
This patch also eliminates build time warning caused by no caller
of monitor_qapi_event_throttle().
Again, my suggestion on 6/29 could avoid that warning; if you use that
workaround, don't clean it until 29/29, but you
On 06/05/2014 06:22 AM, Wenchao Xia wrote:
> This patch also eliminates build time warning caused by no caller
> of monitor_qapi_event_throttle().
Again, my suggestion on 6/29 could avoid that warning; if you use that
workaround, don't clean it until 29/29, but you can drop this paragraph
of this
This patch also eliminates build time warning caused by no caller
of monitor_qapi_event_throttle().
Signed-off-by: Wenchao Xia
---
docs/qmp/qmp-events.txt | 16
hw/ppc/spapr_rtas.c |3 ++-
hw/timer/mc146818rtc.c |3 ++-
include/sysemu/sysemu.h |2 --
monitor.c
