Re: [Qemu-devel] [PATCH V6 17/29] qapi event: convert WATCHDOG

2014-06-17 Thread Eric Blake
On 06/17/2014 03:23 AM, Paolo Bonzini wrote: > Il 13/06/2014 23:47, Eric Blake ha scritto: >>> +## >>> > +# @WatchdogExpirationAction >> I think you will be better off to ensure that error.json is >> self-sufficient, perhaps by sticking any data type it references >> directly into common.json rathe

Re: [Qemu-devel] [PATCH V6 17/29] qapi event: convert WATCHDOG

2014-06-17 Thread Paolo Bonzini
Il 13/06/2014 23:47, Eric Blake ha scritto: +## > +# @WatchdogExpirationAction I think you will be better off to ensure that error.json is self-sufficient, perhaps by sticking any data type it references directly into common.json rather than qapi-schema.json, and having error.json include common

Re: [Qemu-devel] [PATCH V6 17/29] qapi event: convert WATCHDOG

2014-06-14 Thread Wenchao Xia
于 2014/6/14 6:05, Eric Blake 写道: On 06/13/2014 03:47 PM, Eric Blake wrote: On 06/05/2014 06:22 AM, Wenchao Xia wrote: Signed-off-by: Wenchao Xia --- docs/qmp/qmp-events.txt | 19 --- hw/watchdog/watchdog.c | 23 +++ monitor.c |2 +-

Re: [Qemu-devel] [PATCH V6 17/29] qapi event: convert WATCHDOG

2014-06-13 Thread Eric Blake
On 06/13/2014 03:47 PM, Eric Blake wrote: > On 06/05/2014 06:22 AM, Wenchao Xia wrote: >> Signed-off-by: Wenchao Xia >> --- >> docs/qmp/qmp-events.txt | 19 --- >> hw/watchdog/watchdog.c | 23 +++ >> monitor.c |2 +- >> qapi-event.json

Re: [Qemu-devel] [PATCH V6 17/29] qapi event: convert WATCHDOG

2014-06-13 Thread Eric Blake
On 06/05/2014 06:22 AM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > docs/qmp/qmp-events.txt | 19 --- > hw/watchdog/watchdog.c | 23 +++ > monitor.c |2 +- > qapi-event.json | 15 +++ > qapi-schema.json

[Qemu-devel] [PATCH V6 17/29] qapi event: convert WATCHDOG

2014-06-05 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- docs/qmp/qmp-events.txt | 19 --- hw/watchdog/watchdog.c | 23 +++ monitor.c |2 +- qapi-event.json | 15 +++ qapi-schema.json| 24 5 files changed, 4