Re: [Qemu-devel] [PATCH V7 03/11] qapi-script: remember line number in schema parsing

2014-02-21 Thread Markus Armbruster
Wenchao Xia xiaw...@linux.vnet.ibm.com writes: Thanks for your quick review, I'll respin it next week. Looking forward to it. I think we're very close to merge.

Re: [Qemu-devel] [PATCH V7 03/11] qapi-script: remember line number in schema parsing

2014-02-20 Thread Markus Armbruster
Wenchao Xia xiaw...@linux.vnet.ibm.com writes: Before this patch, 'QAPISchemaError' scans whole input until 'pos' to get error line number. After this patch, the scan is avoided since line number is remembered in schema parsing. This patch also benefits other error report functions, which

Re: [Qemu-devel] [PATCH V7 03/11] qapi-script: remember line number in schema parsing

2014-02-20 Thread Wenchao Xia
于 2014/2/20 20:22, Markus Armbruster 写道: Wenchao Xia xiaw...@linux.vnet.ibm.com writes: Before this patch, 'QAPISchemaError' scans whole input until 'pos' to get error line number. After this patch, the scan is avoided since line number is remembered in schema parsing. This patch also

[Qemu-devel] [PATCH V7 03/11] qapi-script: remember line number in schema parsing

2014-02-19 Thread Wenchao Xia
Before this patch, 'QAPISchemaError' scans whole input until 'pos' to get error line number. After this patch, the scan is avoided since line number is remembered in schema parsing. This patch also benefits other error report functions, which would be introduced later. Signed-off-by: Wenchao Xia