Re: [Qemu-devel] [PATCH V7 2/6] qcow2: add error message in qcow2_write_snapshots()

2013-12-20 Thread Stefan Hajnoczi
On Thu, Dec 05, 2013 at 08:02:48PM +0800, Wenchao Xia wrote: > @@ -227,24 +236,40 @@ static int qcow2_write_snapshots(BlockDriverState *bs) > > ret = bdrv_pwrite(bs->file, offset, &h, sizeof(h)); > if (ret < 0) { > +error_setg_errno(errp, -ret, > +

[Qemu-devel] [PATCH V7 2/6] qcow2: add error message in qcow2_write_snapshots()

2013-12-05 Thread Wenchao Xia
The function still returns int since qcow2_snapshot_delete() will return the number. Signed-off-by: Wenchao Xia Reviewed-by: Max Reitz --- block/qcow2-snapshot.c | 43 +-- 1 files changed, 37 insertions(+), 6 deletions(-) diff --git a/block/qcow2-snaps