Re: [Qemu-devel] [PATCH V7 4/6] qemu-img: add -l for snapshot in convert

2013-12-15 Thread Wenchao Xia
于 2013/12/13 21:44, Eric Blake 写道: On 12/08/2013 08:43 PM, Wenchao Xia wrote: convert -s snapshot.name=name1 Previous I planned to use -l for internal snapshot in all possible program, since -s is taken as external snapshot in qemu, qemu-nbd. Consistency in command line options between

Re: [Qemu-devel] [PATCH V7 4/6] qemu-img: add -l for snapshot in convert

2013-12-13 Thread Eric Blake
On 12/08/2013 08:43 PM, Wenchao Xia wrote: convert -s snapshot.name=name1 Previous I planned to use -l for internal snapshot in all possible program, since -s is taken as external snapshot in qemu, qemu-nbd. Consistency in command line options between different tools is nice, but is less

Re: [Qemu-devel] [PATCH V7 4/6] qemu-img: add -l for snapshot in convert

2013-12-08 Thread Wenchao Xia
convert -s snapshot.name=name1 Previous I planned to use -l for internal snapshot in all possible program, since -s is taken as external snapshot in qemu, qemu-nbd. let -s stands for internal in qemu-img convert only, may bring confuse to user, so I deprecated it instead of enhance it(I

[Qemu-devel] [PATCH V7 4/6] qemu-img: add -l for snapshot in convert

2013-12-04 Thread Wenchao Xia
Now qemu-img convert have similar options as qemu-nbd for internal snapshot. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- qemu-img-cmds.hx |4 ++-- qemu-img.c | 44 +++- qemu-img.texi| 12 3 files changed, 45

Re: [Qemu-devel] [PATCH V7 4/6] qemu-img: add -l for snapshot in convert

2013-12-04 Thread Eric Blake
On 12/04/2013 02:10 AM, Wenchao Xia wrote: Now qemu-img convert have similar options as qemu-nbd for internal snapshot. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- @@ -1183,6 +1189,18 @@ static int img_convert(int argc, char **argv) case 's':

Re: [Qemu-devel] [PATCH V7 4/6] qemu-img: add -l for snapshot in convert

2013-12-04 Thread Wenchao Xia
于 2013/12/5 4:42, Eric Blake 写道: On 12/04/2013 02:10 AM, Wenchao Xia wrote: Now qemu-img convert have similar options as qemu-nbd for internal snapshot. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- @@ -1183,6 +1189,18 @@ static int img_convert(int argc, char **argv)