Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2019-09-16 Thread Michael S. Tsirkin
On Mon, Dec 24, 2018 at 04:11:43PM +0800, Yi Zhang wrote: > On 2018-12-21 at 11:36:07 -0500, Michael S. Tsirkin wrote: > > On Fri, Dec 21, 2018 at 11:18:18AM +0800, Yi Zhang wrote: > > > On 2018-12-20 at 09:06:41 -0500, Michael S. Tsirkin wrote: > > > > On Thu, Dec 20, 2018 at 01:37:40PM +0800, Yi

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-24 Thread Yi Zhang
On 2018-12-21 at 11:36:07 -0500, Michael S. Tsirkin wrote: > On Fri, Dec 21, 2018 at 11:18:18AM +0800, Yi Zhang wrote: > > On 2018-12-20 at 09:06:41 -0500, Michael S. Tsirkin wrote: > > > On Thu, Dec 20, 2018 at 01:37:40PM +0800, Yi Zhang wrote: > > > > On 2018-12-19 at 22:42:07 -0500, Michael S.

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-21 Thread Michael S. Tsirkin
On Fri, Dec 21, 2018 at 11:18:18AM +0800, Yi Zhang wrote: > On 2018-12-20 at 09:06:41 -0500, Michael S. Tsirkin wrote: > > On Thu, Dec 20, 2018 at 01:37:40PM +0800, Yi Zhang wrote: > > > On 2018-12-19 at 22:42:07 -0500, Michael S. Tsirkin wrote: > > > > On Thu, Dec 20, 2018 at 11:03:12AM +0800, Yi

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-20 Thread Yi Zhang
On 2018-12-20 at 09:06:41 -0500, Michael S. Tsirkin wrote: > On Thu, Dec 20, 2018 at 01:37:40PM +0800, Yi Zhang wrote: > > On 2018-12-19 at 22:42:07 -0500, Michael S. Tsirkin wrote: > > > On Thu, Dec 20, 2018 at 11:03:12AM +0800, Yi Zhang wrote: > > > > On 2018-12-19 at 10:59:10 -0500, Michael S.

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-20 Thread Michael S. Tsirkin
On Thu, Dec 20, 2018 at 01:37:40PM +0800, Yi Zhang wrote: > On 2018-12-19 at 22:42:07 -0500, Michael S. Tsirkin wrote: > > On Thu, Dec 20, 2018 at 11:03:12AM +0800, Yi Zhang wrote: > > > On 2018-12-19 at 10:59:10 -0500, Michael S. Tsirkin wrote: > > > > On Wed, Dec 19, 2018 at 05:10:18PM +0800, Yi

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-19 Thread Yi Zhang
On 2018-12-19 at 22:42:07 -0500, Michael S. Tsirkin wrote: > On Thu, Dec 20, 2018 at 11:03:12AM +0800, Yi Zhang wrote: > > On 2018-12-19 at 10:59:10 -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 19, 2018 at 05:10:18PM +0800, Yi Zhang wrote: > > > > > > + > > > > > > + - 'sync' option of

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-19 Thread Michael S. Tsirkin
On Thu, Dec 20, 2018 at 11:03:12AM +0800, Yi Zhang wrote: > On 2018-12-19 at 10:59:10 -0500, Michael S. Tsirkin wrote: > > On Wed, Dec 19, 2018 at 05:10:18PM +0800, Yi Zhang wrote: > > > > > + > > > > > + - 'sync' option of memory-backend-file is not 'off', and > > > > > + > > > > > + - 'share'

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-19 Thread Yi Zhang
On 2018-12-19 at 10:59:10 -0500, Michael S. Tsirkin wrote: > On Wed, Dec 19, 2018 at 05:10:18PM +0800, Yi Zhang wrote: > > > > + > > > > + - 'sync' option of memory-backend-file is not 'off', and > > > > + > > > > + - 'share' option of memory-backend-file is 'on'. > > > > + > > > > + - 'pmem'

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-19 Thread Michael S. Tsirkin
On Wed, Dec 19, 2018 at 05:10:18PM +0800, Yi Zhang wrote: > > > + > > > + - 'sync' option of memory-backend-file is not 'off', and > > > + > > > + - 'share' option of memory-backend-file is 'on'. > > > + > > > + - 'pmem' option of memory-backend-file is 'on' > > > + > > > > Wait isn't this what

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-19 Thread Yi Zhang
On 2018-12-18 at 09:18:50 -0500, Michael S. Tsirkin wrote: > On Tue, Dec 18, 2018 at 04:17:39PM +0800, Zhang Yi wrote: > > This option controls whether QEMU mmap(2) > > will mmap > > > the memory backend file with > > MAP_SYNC flag, which could consistent filesystem metadata > > I'm not sure

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-18 Thread Michael S. Tsirkin
On Tue, Dec 18, 2018 at 04:17:39PM +0800, Zhang Yi wrote: > This option controls whether QEMU mmap(2) will mmap > the memory backend file with > MAP_SYNC flag, which could consistent filesystem metadata I'm not sure what does "which could consistent" above mean. > for each guest > write, if

[Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-18 Thread Zhang Yi
This option controls whether QEMU mmap(2) the memory backend file with MAP_SYNC flag, which could consistent filesystem metadata for each guest write, if MAP_SYNC flag is supported by the host kernel(Linux kernel 4.15 and later) and the backend is a file supporting DAX (e.g., file on ext4/xfs file