Re: [Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name

2014-03-04 Thread Markus Armbruster
Wenchao Xia wenchaoq...@gmail.com writes: This series address two issues: 1. support using enum as discriminator in union. For example, if we have following define in qapi schema: { 'enum': 'EnumOne', 'data': [ 'value1', 'value2', 'value3' ] } { 'type': 'UserDefBase0', 'data': {

Re: [Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name

2014-03-04 Thread Luiz Capitulino
On Tue, 04 Mar 2014 14:03:34 +0100 Markus Armbruster arm...@redhat.com wrote: Wenchao Xia wenchaoq...@gmail.com writes: This series address two issues: 1. support using enum as discriminator in union. For example, if we have following define in qapi schema: { 'enum': 'EnumOne',

Re: [Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name

2014-03-04 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Tue, 04 Mar 2014 14:03:34 +0100 Markus Armbruster arm...@redhat.com wrote: [] Applies cleanly on Luiz's queue/qmp branch. I got a few questions on 04/10, but nothing major. Perhaps you'd like to respin to address the nits picked by

Re: [Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name

2014-03-04 Thread Wenchao Xia
于 2014/3/4 21:53, Markus Armbruster 写道: Luiz Capitulino lcapitul...@redhat.com writes: On Tue, 04 Mar 2014 14:03:34 +0100 Markus Armbruster arm...@redhat.com wrote: [] Applies cleanly on Luiz's queue/qmp branch. I got a few questions on 04/10, but nothing major. Perhaps you'd like to

Re: [Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name

2014-02-28 Thread Wenchao Xia
Markus, do you like the way this version works?

Re: [Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name

2014-02-28 Thread Markus Armbruster
Wenchao Xia wenchaoq...@gmail.com writes: Markus, do you like the way this version works? I hope to review it early next week.

[Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name

2014-02-27 Thread Wenchao Xia
This series address two issues: 1. support using enum as discriminator in union. For example, if we have following define in qapi schema: { 'enum': 'EnumOne', 'data': [ 'value1', 'value2', 'value3' ] } { 'type': 'UserDefBase0', 'data': { 'base-string0': 'str', 'base-enum0': 'EnumOne' } }