-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Il 22/08/2013 04:29, Eric Blake ha scritto:
> If everything is optional, then what defaults are used if
> I specify nothing? Should nodeid be mandatory (here, and
> in NumaNodeOptions)?
>>>
>>> The defaults are all consistent with origina
On 08/22/13 18:14, Eric Blake wrote:
> On 08/22/2013 02:46 AM, Laszlo Ersek wrote:
>> Yes. This part of the schema is not for exposure over QMP, it just
>> generates stuff for OptsVisitor, and it must remain compatible with the
>> original, manual parsing of the option.
>>
>> This came up for V6:
>
On 08/22/2013 02:46 AM, Laszlo Ersek wrote:
> Yes. This part of the schema is not for exposure over QMP, it just
> generates stuff for OptsVisitor, and it must remain compatible with the
> original, manual parsing of the option.
>
> This came up for V6:
>
> http://thread.gmane.org/gmane.comp.emul
On 08/22/13 05:16, Wanlong Gao wrote:
> On 08/22/2013 10:29 AM, Eric Blake wrote:
>> On 08/21/2013 07:12 PM, Wanlong Gao wrote:
>>
> + '*mem':'str' }}
Why is size passed as a 'str' instead of an integral type? If anything,
at the QMP layer, it should be an integer represen
On 08/22/2013 10:29 AM, Eric Blake wrote:
> On 08/21/2013 07:12 PM, Wanlong Gao wrote:
>
+ '*mem':'str' }}
>>>
>>> Why is size passed as a 'str' instead of an integral type? If anything,
>>> at the QMP layer, it should be an integer representing size in bytes
>>> (the command line and
On 08/21/2013 07:12 PM, Wanlong Gao wrote:
>>> + '*mem':'str' }}
>>
>> Why is size passed as a 'str' instead of an integral type? If anything,
>> at the QMP layer, it should be an integer representing size in bytes
>> (the command line and HMP are already capable of converting shorthand
>>
On 08/22/2013 04:59 AM, Eric Blake wrote:
> On 08/19/2013 07:07 PM, Wanlong Gao wrote:
>> Reviewed-by: Laszlo Ersek
>> Signed-off-by: Wanlong Gao
>> ---
>> qapi-schema.json | 47 +++
>> 1 file changed, 47 insertions(+)
>>
>
>> +##
>> +# @NumaNodeOptio
On 08/19/2013 07:07 PM, Wanlong Gao wrote:
> Reviewed-by: Laszlo Ersek
> Signed-off-by: Wanlong Gao
> ---
> qapi-schema.json | 47 +++
> 1 file changed, 47 insertions(+)
>
> +##
> +# @NumaNodeOptions
> +#
> +# Create a guest NUMA node.
> +#
> +# @nod
Reviewed-by: Laszlo Ersek
Signed-off-by: Wanlong Gao
---
qapi-schema.json | 47 +++
1 file changed, 47 insertions(+)
diff --git a/qapi-schema.json b/qapi-schema.json
index a51f7d2..b9b18e4 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3773,
