Re: [Qemu-devel] [PATCH V8 2/5] util/mmap-alloc: switch qemu_ram_mmap() to 'flags' parameter

2019-01-14 Thread Michael S. Tsirkin
On Tue, Jan 15, 2019 at 10:39:14AM +0800, Yi Zhang wrote: > > It's needed for this series but yes, this ifdefery belongs in > > a more central header. Maybe qemu/osdep.h > > And it needs documentation and be a separate patch. > Agree, Thank Michael's explanation, better to doing this in a separate

Re: [Qemu-devel] [PATCH V8 2/5] util/mmap-alloc: switch qemu_ram_mmap() to 'flags' parameter

2019-01-14 Thread Yi Zhang
On 2019-01-14 at 14:04:25 -0500, Michael S. Tsirkin wrote: > On Mon, Jan 14, 2019 at 04:50:36PM -0200, Eduardo Habkost wrote: > > On Wed, Jan 02, 2019 at 01:26:06PM +0800, Zhang Yi wrote: > > > As more flag parameters besides the existing 'shared' are going to be > > > added to qemu_ram_mmap(), let

Re: [Qemu-devel] [PATCH V8 2/5] util/mmap-alloc: switch qemu_ram_mmap() to 'flags' parameter

2019-01-14 Thread Michael S. Tsirkin
On Mon, Jan 14, 2019 at 04:50:36PM -0200, Eduardo Habkost wrote: > On Wed, Jan 02, 2019 at 01:26:06PM +0800, Zhang Yi wrote: > > As more flag parameters besides the existing 'shared' are going to be > > added to qemu_ram_mmap(), let's switch 'shared' to a 'flags' parameter > > in advance, so as to

Re: [Qemu-devel] [PATCH V8 2/5] util/mmap-alloc: switch qemu_ram_mmap() to 'flags' parameter

2019-01-14 Thread Eduardo Habkost
On Wed, Jan 02, 2019 at 01:26:06PM +0800, Zhang Yi wrote: > As more flag parameters besides the existing 'shared' are going to be > added to qemu_ram_mmap(), let's switch 'shared' to a 'flags' parameter > in advance, so as to ease the further additions. > > Signed-off-by: Haozhong Zhang > Signed-

[Qemu-devel] [PATCH V8 2/5] util/mmap-alloc: switch qemu_ram_mmap() to 'flags' parameter

2019-01-01 Thread Zhang Yi
As more flag parameters besides the existing 'shared' are going to be added to qemu_ram_mmap(), let's switch 'shared' to a 'flags' parameter in advance, so as to ease the further additions. Signed-off-by: Haozhong Zhang Signed-off-by: Zhang Yi --- exec.c| 7 --- include