Re: [Qemu-devel] [PATCH for-1.4] Revert e1000: no need auto-negotiation if link was down

2013-02-04 Thread Michael S. Tsirkin
On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. I'm not sure what issue the original commit was meant to fix, or if the logic is actually wrong, but it causes e1000 to stop working after a guest issues a reset.

Re: [Qemu-devel] [PATCH for-1.4] Revert e1000: no need auto-negotiation if link was down

2013-02-04 Thread Stefan Hajnoczi
On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. I'm not sure what issue the original commit was meant to fix, or if the logic is actually wrong, but it causes e1000 to stop working after a guest issues a reset.

Re: [Qemu-devel] [PATCH for-1.4] Revert e1000: no need auto-negotiation if link was down

2013-02-04 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.4] Revert e1000: no need auto-negotiation if link was down

2013-02-01 Thread mdroth
On Fri, Feb 01, 2013 at 03:20:59PM +0800, Amos Kong wrote: On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. I'm not sure what issue the original commit was meant to fix, or if the logic is actually wrong, but it

Re: [Qemu-devel] [PATCH for-1.4] Revert e1000: no need auto-negotiation if link was down

2013-02-01 Thread mdroth
On Fri, Feb 01, 2013 at 03:53:22PM +0800, Amos Kong wrote: On Fri, Feb 01, 2013 at 03:20:59PM +0800, Amos Kong wrote: On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. I'm not sure what issue the original commit

Re: [Qemu-devel] [PATCH for-1.4] Revert e1000: no need auto-negotiation if link was down

2013-02-01 Thread Anthony Liguori
Michael Roth mdr...@linux.vnet.ibm.com writes: This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. I'm not sure what issue the original commit was meant to fix, or if the logic is actually wrong, but it causes e1000 to stop working after a guest issues a reset. From what I can

Re: [Qemu-devel] [PATCH for-1.4] Revert e1000: no need auto-negotiation if link was down

2013-02-01 Thread Amos Kong
On Fri, Feb 01, 2013 at 08:49:00AM -0600, mdroth wrote: On Fri, Feb 01, 2013 at 03:53:22PM +0800, Amos Kong wrote: On Fri, Feb 01, 2013 at 03:20:59PM +0800, Amos Kong wrote: On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: This reverts commit

Re: [Qemu-devel] [PATCH for-1.4] Revert e1000: no need auto-negotiation if link was down

2013-02-01 Thread Amos Kong
On Fri, Feb 01, 2013 at 08:29:48AM -0600, mdroth wrote: On Fri, Feb 01, 2013 at 03:20:59PM +0800, Amos Kong wrote: On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. I'm not sure what issue the original commit

[Qemu-devel] [PATCH for-1.4] Revert e1000: no need auto-negotiation if link was down

2013-01-31 Thread Michael Roth
This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. I'm not sure what issue the original commit was meant to fix, or if the logic is actually wrong, but it causes e1000 to stop working after a guest issues a reset. From what I can tell a guest with an e1000 nic has no way of changing

Re: [Qemu-devel] [PATCH for-1.4] Revert e1000: no need auto-negotiation if link was down

2013-01-31 Thread Amos Kong
On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. I'm not sure what issue the original commit was meant to fix, or if the logic is actually wrong, but it causes e1000 to stop working after a guest issues a reset. Hi

Re: [Qemu-devel] [PATCH for-1.4] Revert e1000: no need auto-negotiation if link was down

2013-01-31 Thread Amos Kong
On Fri, Feb 01, 2013 at 03:20:59PM +0800, Amos Kong wrote: On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. I'm not sure what issue the original commit was meant to fix, or if the logic is actually wrong, but it