Re: [Qemu-devel] [PATCH for-1.4 03/12] pc: Reverse pc_init_pci() compatibility logic

2013-01-21 Thread Marcelo Tosatti
On Thu, Jan 17, 2013 at 06:59:29PM -0200, Eduardo Habkost wrote: > Currently, the pc-1.4 machine init function enables PV EOI and then > calls the pc-1.2 machine init function. The problem with this approach > is that now we can't enable any additional compatibility code inside the > pc-1.2 init fu

Re: [Qemu-devel] [PATCH for-1.4 03/12] pc: Reverse pc_init_pci() compatibility logic

2013-01-21 Thread Eduardo Habkost
On Mon, Jan 21, 2013 at 04:39:24AM +0100, Andreas Färber wrote: > Am 17.01.2013 21:59, schrieb Eduardo Habkost: > > Currently, the pc-1.4 machine init function enables PV EOI and then > > calls the pc-1.2 machine init function. The problem with this approach > > is that now we can't enable any addi

Re: [Qemu-devel] [PATCH for-1.4 03/12] pc: Reverse pc_init_pci() compatibility logic

2013-01-21 Thread Michael S. Tsirkin
On Thu, Jan 17, 2013 at 06:59:29PM -0200, Eduardo Habkost wrote: > Currently, the pc-1.4 machine init function enables PV EOI and then > calls the pc-1.2 machine init function. The problem with this approach > is that now we can't enable any additional compatibility code inside the > pc-1.2 init fu

Re: [Qemu-devel] [PATCH for-1.4 03/12] pc: Reverse pc_init_pci() compatibility logic

2013-01-20 Thread Andreas Färber
Am 17.01.2013 21:59, schrieb Eduardo Habkost: > Currently, the pc-1.4 machine init function enables PV EOI and then > calls the pc-1.2 machine init function. The problem with this approach > is that now we can't enable any additional compatibility code inside the > pc-1.2 init function because it w

[Qemu-devel] [PATCH for-1.4 03/12] pc: Reverse pc_init_pci() compatibility logic

2013-01-17 Thread Eduardo Habkost
Currently, the pc-1.4 machine init function enables PV EOI and then calls the pc-1.2 machine init function. The problem with this approach is that now we can't enable any additional compatibility code inside the pc-1.2 init function because it would end up enabling the compatibility behavior on pc-