Laszlo Ersek writes:
> On 02/19/13 10:50, Markus Armbruster wrote:
>
>> I suspect the real failure is in patch review.
>>
>> We can't expect everyone to know every feature, such as repeating
>> options. But we need to catch wheel reinventions in review.
>
> I'd like to agree, but I'm simply una
On 02/19/13 10:29, Markus Armbruster wrote:
> When it is, I'd suggest to try something like:
>
> * Create a schema appropriate for QMP. This results in a C data
> structure (generated) and code accepting it. Let's call the latter
> "the interface".
>
> * Create a schema for an opts-visitor
On 02/19/13 10:50, Markus Armbruster wrote:
> I suspect the real failure is in patch review.
>
> We can't expect everyone to know every feature, such as repeating
> options. But we need to catch wheel reinventions in review.
I'd like to agree, but I'm simply unable to review more. On a good day
Laszlo Ersek writes:
> Hi,
>
> sorry for the late answer. I can only address the netdev_add /
> opts-visitor stuff now.
>
> On 02/14/13 17:36, Luiz Capitulino wrote:
>> On Thu, 14 Feb 2013 14:31:50 +0100
>> Markus Armbruster wrote:
>>> Luiz Capitulino writes:
On Thu, 14 Feb 2013 10:45:22 +
Laszlo Ersek writes:
> On 02/15/13 01:20, Laszlo Ersek wrote:
>> On 02/14/13 17:36, Luiz Capitulino wrote:
>>> On Thu, 14 Feb 2013 14:31:50 +0100
>>> Markus Armbruster wrote:
>
chardev-add: the schema defines an object type for each backend
(ChardevFile, ChardevSocket, ...), and collec
On 02/15/13 01:20, Laszlo Ersek wrote:
> On 02/14/13 17:36, Luiz Capitulino wrote:
>> On Thu, 14 Feb 2013 14:31:50 +0100
>> Markus Armbruster wrote:
>>> chardev-add: the schema defines an object type for each backend
>>> (ChardevFile, ChardevSocket, ...), and collects them together in
>>> discrim
Hi,
sorry for the late answer. I can only address the netdev_add /
opts-visitor stuff now.
On 02/14/13 17:36, Luiz Capitulino wrote:
> On Thu, 14 Feb 2013 14:31:50 +0100
> Markus Armbruster wrote:
>> Luiz Capitulino writes:
>>> On Thu, 14 Feb 2013 10:45:22 +0100
>>> Markus Armbruster wrote:
>
On Thu, 14 Feb 2013 14:31:50 +0100
Markus Armbruster wrote:
> [Some quoted material restored]
>
> Luiz Capitulino writes:
>
> > On Thu, 14 Feb 2013 10:45:22 +0100
> > Markus Armbruster wrote:
> >
> >> [Note cc: +Laszlo, +Anthony, -qemu-trivial]
> >>
> >> Luiz Capitulino writes:
> >>
> >> >
[Some quoted material restored]
Luiz Capitulino writes:
> On Thu, 14 Feb 2013 10:45:22 +0100
> Markus Armbruster wrote:
>
>> [Note cc: +Laszlo, +Anthony, -qemu-trivial]
>>
>> Luiz Capitulino writes:
>>
>> > On Fri, 08 Feb 2013 20:34:20 +0100
>> > Markus Armbruster wrote:
>> >
>> >> > The re
On Thu, 14 Feb 2013 10:45:22 +0100
Markus Armbruster wrote:
> [Note cc: +Laszlo, +Anthony, -qemu-trivial]
>
> Luiz Capitulino writes:
>
> > On Fri, 08 Feb 2013 20:34:20 +0100
> > Markus Armbruster wrote:
> >
> >> > The real problem here is that the k, M, G suffixes, for example, are not
> >>
[Note cc: +Laszlo, +Anthony, -qemu-trivial]
Luiz Capitulino writes:
> On Fri, 08 Feb 2013 20:34:20 +0100
> Markus Armbruster wrote:
>
>> > The real problem here is that the k, M, G suffixes, for example, are not
>> > good to be reported by QMP. So maybe we should refactor the code in a way
>> >
On Fri, 08 Feb 2013 20:34:20 +0100
Markus Armbruster wrote:
> > The real problem here is that the k, M, G suffixes, for example, are not
> > good to be reported by QMP. So maybe we should refactor the code in a way
> > that we separate what's done in QMP from what is done in HMP/command-line.
>
Luiz Capitulino writes:
> On Fri, 08 Feb 2013 19:58:42 +0100
> Markus Armbruster wrote:
>
>> Luiz Capitulino writes:
>>
>> > On Fri, 8 Feb 2013 17:17:10 +0100
>> > Markus Armbruster wrote:
>> >
>> >> commit 8be7e7e4 and commit ec7b2ccb messed up the ordering of error
>> >> message and the he
Luiz Capitulino writes:
> On Fri, 8 Feb 2013 17:17:10 +0100
> Markus Armbruster wrote:
>
>> commit 8be7e7e4 and commit ec7b2ccb messed up the ordering of error
>> message and the helpful explanation that should follow it, like this:
>>
>> $ qemu-system-x86_64 --nodefaults -S --vnc :0 --cha
On Fri, 08 Feb 2013 19:58:42 +0100
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > On Fri, 8 Feb 2013 17:17:10 +0100
> > Markus Armbruster wrote:
> >
> >> commit 8be7e7e4 and commit ec7b2ccb messed up the ordering of error
> >> message and the helpful explanation that should follow i
On Fri, 8 Feb 2013 17:17:10 +0100
Markus Armbruster wrote:
> commit 8be7e7e4 and commit ec7b2ccb messed up the ordering of error
> message and the helpful explanation that should follow it, like this:
>
> $ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=,
> Identifiers co
commit 8be7e7e4 and commit ec7b2ccb messed up the ordering of error
message and the helpful explanation that should follow it, like this:
$ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=,
Identifiers consist of letters, digits, '-', '.', '_', starting with a
letter.
qe
17 matches
Mail list logo
