Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

2013-05-15 Thread Paolo Bonzini
Il 15/05/2013 18:22, Markus Armbruster ha scritto: > Paolo Bonzini writes: > >> Il 15/05/2013 17:09, Markus Armbruster ha scritto: >>> @@ -209,7 +209,7 @@ void pc_system_firmware_init(MemoryRegion >>> *rom_memory) >>> * TODO This device exists only so that users can switch betw

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

2013-05-15 Thread Markus Armbruster
Paolo Bonzini writes: > Il 15/05/2013 17:09, Markus Armbruster ha scritto: >> @@ -209,7 +209,7 @@ void pc_system_firmware_init(MemoryRegion >> *rom_memory) >> * TODO This device exists only so that users can switch between >> * use of flash and ROM for the BIOS. The

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

2013-05-15 Thread Paolo Bonzini
Il 15/05/2013 17:09, Markus Armbruster ha scritto: > @@ -209,7 +209,7 @@ void pc_system_firmware_init(MemoryRegion *rom_memory) > * TODO This device exists only so that users can switch between > * use of flash and ROM for the BIOS. The ability to switch was > * c

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

2013-05-15 Thread Markus Armbruster
Paolo Bonzini writes: > Il 15/05/2013 16:28, Markus Armbruster ha scritto: >> Sorry for the delay, I was off for a few days. >> >> Anthony Liguori writes: >> >>> Paolo Bonzini writes: >>> This reverts commit 9953f8822cc316eec9962f0a2858c3439a80adec. While Markus's analysis is entire

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

2013-05-15 Thread Paolo Bonzini
Il 15/05/2013 16:28, Markus Armbruster ha scritto: > Sorry for the delay, I was off for a few days. > > Anthony Liguori writes: > >> Paolo Bonzini writes: >> >>> This reverts commit 9953f8822cc316eec9962f0a2858c3439a80adec. >>> While Markus's analysis is entirely correct, there are 1.6 patches

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

2013-05-15 Thread Markus Armbruster
Sorry for the delay, I was off for a few days. Anthony Liguori writes: > Paolo Bonzini writes: > >> This reverts commit 9953f8822cc316eec9962f0a2858c3439a80adec. >> While Markus's analysis is entirely correct, there are 1.6 patches >> that fix the bug for real and without requiring machine type

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

2013-05-13 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

2013-05-10 Thread Anthony Liguori
Paolo Bonzini writes: > This reverts commit 9953f8822cc316eec9962f0a2858c3439a80adec. > While Markus's analysis is entirely correct, there are 1.6 patches > that fix the bug for real and without requiring machine type hacks. > Let's think of the children who will have to read this code, and > avo

[Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

2013-05-10 Thread Paolo Bonzini
This reverts commit 9953f8822cc316eec9962f0a2858c3439a80adec. While Markus's analysis is entirely correct, there are 1.6 patches that fix the bug for real and without requiring machine type hacks. Let's think of the children who will have to read this code, and avoid a complicated mess of semantics