Re: [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization

2013-08-18 Thread Paolo Bonzini
Il 13/08/2013 17:57, Andreas Färber ha scritto: > Am 13.08.2013 17:27, schrieb Paolo Bonzini: >> All that should happen is that after migration you will not get panic >> notifications on the destination. > > Well, how does the Linux driver cope with pvpanic device present on boot > but not present

Re: [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization

2013-08-13 Thread Anthony Liguori
Andreas Färber writes: > Am 13.08.2013 17:27, schrieb Paolo Bonzini: >> Il 13/08/2013 17:11, Andreas Färber ha scritto: >>> >>> mst suggested to patch stable-1.5 to disable it there, too. I am not >>> against but have doubts as to how well that works with migration, since >>> 1.5.3 is still a bit

Re: [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization

2013-08-13 Thread Andreas Färber
Am 13.08.2013 17:27, schrieb Paolo Bonzini: > Il 13/08/2013 17:11, Andreas Färber ha scritto: >> >> mst suggested to patch stable-1.5 to disable it there, too. I am not >> against but have doubts as to how well that works with migration, since >> 1.5.3 is still a bit off and I would expect 1.5.2 ->

Re: [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization

2013-08-13 Thread Paolo Bonzini
Il 13/08/2013 17:11, Andreas Färber ha scritto: > > mst suggested to patch stable-1.5 to disable it there, too. I am not > against but have doubts as to how well that works with migration, since > 1.5.3 is still a bit off and I would expect 1.5.2 -> 1.6.0 migration to > work without guest-visible

Re: [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization

2013-08-13 Thread Michael S. Tsirkin
On Tue, Aug 13, 2013 at 05:11:08PM +0200, Andreas Färber wrote: > Am 13.08.2013 16:54, schrieb Paolo Bonzini: > > Il 13/08/2013 16:11, Anthony Liguori ha scritto: > Fix this up, clean up a trivial code duplication > and add a comment explaining why we special-case 1.5 > with respect

Re: [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization

2013-08-13 Thread Andreas Färber
Am 13.08.2013 16:54, schrieb Paolo Bonzini: > Il 13/08/2013 16:11, Anthony Liguori ha scritto: Fix this up, clean up a trivial code duplication and add a comment explaining why we special-case 1.5 with respect to pvpanic. Reported-by: Markus Armbruster Signed-off-by:

Re: [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization

2013-08-13 Thread Paolo Bonzini
Il 13/08/2013 16:11, Anthony Liguori ha scritto: >> > Fix this up, clean up a trivial code duplication >> > and add a comment explaining why we special-case 1.5 >> > with respect to pvpanic. >> > >> > Reported-by: Markus Armbruster >> > Signed-off-by: Michael S. Tsirkin > Thanks for catching this

Re: [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization

2013-08-13 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > commit 7f3e341a008c585deed174eaf1f826c88c67948a > hw/misc: don't create pvpanic device by default > was mismerged: as a result, pvpanic is enabled in 1.6 > > Fix this up, clean up a trivial code duplication > and add a comment explaining why we special-case 1.5

Re: [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization

2013-08-13 Thread Eric Blake
On 08/13/2013 06:53 AM, Michael S. Tsirkin wrote: > commit 7f3e341a008c585deed174eaf1f826c88c67948a > hw/misc: don't create pvpanic device by default > was mismerged: as a result, pvpanic is enabled in 1.6 > > Fix this up, clean up a trivial code duplication > and add a comment explaining why

[Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization

2013-08-13 Thread Michael S. Tsirkin
commit 7f3e341a008c585deed174eaf1f826c88c67948a hw/misc: don't create pvpanic device by default was mismerged: as a result, pvpanic is enabled in 1.6 Fix this up, clean up a trivial code duplication and add a comment explaining why we special-case 1.5 with respect to pvpanic. Reported-by: Mar