Re: [Qemu-devel] [PATCH for-2.10 0/5] tests: acpi: make sure FADT is compared to reference table

2017-08-02 Thread Michael S. Tsirkin
On Wed, Aug 02, 2017 at 09:51:22AM +0200, Igor Mammedov wrote: > On Wed, 2 Aug 2017 00:14:18 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Jul 31, 2017 at 05:40:47PM +0200, Igor Mammedov wrote: > > > While refactoring i386/FADT generation to build_append_int_noprefix() > > > > >

Re: [Qemu-devel] [PATCH for-2.10 0/5] tests: acpi: make sure FADT is compared to reference table

2017-08-02 Thread Igor Mammedov
On Wed, 2 Aug 2017 00:14:18 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jul 31, 2017 at 05:40:47PM +0200, Igor Mammedov wrote: > > While refactoring i386/FADT generation to build_append_int_noprefix() > > > > and testing it, It turned out that FADT is only tested for valid

Re: [Qemu-devel] [PATCH for-2.10 0/5] tests: acpi: make sure FADT is compared to reference table

2017-08-01 Thread Michael S. Tsirkin
On Mon, Jul 31, 2017 at 05:40:47PM +0200, Igor Mammedov wrote: > While refactoring i386/FADT generation to build_append_int_noprefix() > > and testing it, It turned out that FADT is only tested for valid > > checksum but actual test for unintended changes isn't applie

[Qemu-devel] [PATCH for-2.10 0/5] tests: acpi: make sure FADT is compared to reference table

2017-07-31 Thread Igor Mammedov
While refactoring i386/FADT generation to build_append_int_noprefix() and testing it, It turned out that FADT is only tested for valid checksum but actual test for unintended changes isn't applied to it even though we have reference tables in tree.