Re: [Qemu-devel] [PATCH for-2.11 1/1] blockjob: Make block_job_pause_all() keep a reference to the jobs

2017-11-30 Thread Jeff Cody
On Thu, Nov 30, 2017 at 03:43:35PM +0100, Kevin Wolf wrote: > Am 30.11.2017 um 15:35 hat Alberto Garcia geschrieben: > > On Thu 30 Nov 2017 01:27:32 PM CET, Kevin Wolf wrote: > > > > >> Destroying a paused block job during bdrv_reopen_multiple() has two > > >> consequences: > > >> > > >>1) Th

Re: [Qemu-devel] [PATCH for-2.11 1/1] blockjob: Make block_job_pause_all() keep a reference to the jobs

2017-11-30 Thread Kevin Wolf
Am 30.11.2017 um 15:35 hat Alberto Garcia geschrieben: > On Thu 30 Nov 2017 01:27:32 PM CET, Kevin Wolf wrote: > > >> Destroying a paused block job during bdrv_reopen_multiple() has two > >> consequences: > >> > >>1) The references to the nodes involved in the job are released, > >> pos

Re: [Qemu-devel] [PATCH for-2.11 1/1] blockjob: Make block_job_pause_all() keep a reference to the jobs

2017-11-30 Thread Alberto Garcia
On Thu 30 Nov 2017 01:27:32 PM CET, Kevin Wolf wrote: >> Destroying a paused block job during bdrv_reopen_multiple() has two >> consequences: >> >>1) The references to the nodes involved in the job are released, >> possibly destroying some of them. If those nodes were in the >> re

Re: [Qemu-devel] [PATCH for-2.11 1/1] blockjob: Make block_job_pause_all() keep a reference to the jobs

2017-11-30 Thread Kevin Wolf
Am 29.11.2017 um 18:56 hat Alberto Garcia geschrieben: > Starting from commit 40840e419be31e6a32e6ea24511c74b389d5e0e4 we are > pausing all block jobs during bdrv_reopen_multiple() to prevent any of > them from finishing and removing nodes from the graph while they are > being reopened. > > It tur

[Qemu-devel] [PATCH for-2.11 1/1] blockjob: Make block_job_pause_all() keep a reference to the jobs

2017-11-29 Thread Alberto Garcia
Starting from commit 40840e419be31e6a32e6ea24511c74b389d5e0e4 we are pausing all block jobs during bdrv_reopen_multiple() to prevent any of them from finishing and removing nodes from the graph while they are being reopened. It turns out that pausing a block job doesn't necessarily prevent it from