Re: [Qemu-devel] [PATCH for-2.12] gdbstub: fix off-by-one in gdb_handle_packet()

2018-04-09 Thread Peter Maydell
On 9 April 2018 at 10:39, Paolo Bonzini wrote: > On 09/04/2018 07:58, Stefan Hajnoczi wrote: >> On Sun, Apr 08, 2018 at 11:59:33AM -0300, Philippe Mathieu-Daudé wrote: >>> memtohex() adds an extra trailing NUL character. >>> >>> Reported-by: AddressSanitizer >>> Signed-off-by: Philippe Mathieu-Dau

Re: [Qemu-devel] [PATCH for-2.12] gdbstub: fix off-by-one in gdb_handle_packet()

2018-04-09 Thread Paolo Bonzini
On 09/04/2018 07:58, Stefan Hajnoczi wrote: > On Sun, Apr 08, 2018 at 11:59:33AM -0300, Philippe Mathieu-Daudé wrote: >> memtohex() adds an extra trailing NUL character. >> >> Reported-by: AddressSanitizer >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> (gdb) dump binary memory /tmp/dram.bin 0x

Re: [Qemu-devel] [PATCH for-2.12] gdbstub: fix off-by-one in gdb_handle_packet()

2018-04-08 Thread Stefan Hajnoczi
On Sun, Apr 08, 2018 at 11:59:33AM -0300, Philippe Mathieu-Daudé wrote: > memtohex() adds an extra trailing NUL character. > > Reported-by: AddressSanitizer > Signed-off-by: Philippe Mathieu-Daudé > --- > (gdb) dump binary memory /tmp/dram.bin 0x9400 0x9410 > Remote connection closed > >

[Qemu-devel] [PATCH for-2.12] gdbstub: fix off-by-one in gdb_handle_packet()

2018-04-08 Thread Philippe Mathieu-Daudé
memtohex() adds an extra trailing NUL character. Reported-by: AddressSanitizer Signed-off-by: Philippe Mathieu-Daudé --- (gdb) dump binary memory /tmp/dram.bin 0x9400 0x9410 Remote connection closed = ==22732==ERROR: Address