Re: [Qemu-devel] [PATCH for-2.12] hw/intc/arm_gicv3: Fix secure-GIC NS ICC_PMR and ICC_RPR accesses

2018-03-22 Thread Philippe Mathieu-Daudé
On 03/15/2018 10:34 AM, Peter Maydell wrote: > If the GIC has the security extension support enabled, then a > non-secure access to ICC_PMR must take account of the non-secure > view of interrupt priorities, where real priorities 0..0x7f > are secure-only and not visible to the non-secure guest, an

Re: [Qemu-devel] [PATCH for-2.12] hw/intc/arm_gicv3: Fix secure-GIC NS ICC_PMR and ICC_RPR accesses

2018-03-22 Thread Peter Maydell
On 22 March 2018 at 14:23, Andrew Jones wrote: > On Thu, Mar 15, 2018 at 01:34:41PM +, Peter Maydell wrote: >> If the GIC has the security extension support enabled, then a >> non-secure access to ICC_PMR must take account of the non-secure >> view of interrupt priorities, where real prioritie

Re: [Qemu-devel] [PATCH for-2.12] hw/intc/arm_gicv3: Fix secure-GIC NS ICC_PMR and ICC_RPR accesses

2018-03-22 Thread Andrew Jones
On Thu, Mar 15, 2018 at 01:34:41PM +, Peter Maydell wrote: > If the GIC has the security extension support enabled, then a > non-secure access to ICC_PMR must take account of the non-secure > view of interrupt priorities, where real priorities 0..0x7f > are secure-only and not visible to the no

Re: [Qemu-devel] [PATCH for-2.12] hw/intc/arm_gicv3: Fix secure-GIC NS ICC_PMR and ICC_RPR accesses

2018-03-22 Thread Peter Maydell
Ping for code review -- it would be nice to put this bugfix into rc1. thanks -- PMM On 15 March 2018 at 13:34, Peter Maydell wrote: > If the GIC has the security extension support enabled, then a > non-secure access to ICC_PMR must take account of the non-secure > view of interrupt priorities, w

[Qemu-devel] [PATCH for-2.12] hw/intc/arm_gicv3: Fix secure-GIC NS ICC_PMR and ICC_RPR accesses

2018-03-15 Thread Peter Maydell
If the GIC has the security extension support enabled, then a non-secure access to ICC_PMR must take account of the non-secure view of interrupt priorities, where real priorities 0..0x7f are secure-only and not visible to the non-secure guest, and priorities 0x80..0xff are shown to the guest as if