Re: [Qemu-devel] [PATCH for-2.12] linux-user/signal.c: Ensure AArch64 signal frame isn't too small

2018-04-10 Thread Peter Maydell
On 9 April 2018 at 23:05, Richard Henderson wrote: > On 04/10/2018 12:07 AM, Peter Maydell wrote: >> In particular the dash shell >> would segfault if the frame wasn't as big enough. > > Ah, that was the critical difference in my failure to replicate -- the fedora > sysroot

Re: [Qemu-devel] [PATCH for-2.12] linux-user/signal.c: Ensure AArch64 signal frame isn't too small

2018-04-09 Thread Peter Maydell
On 9 April 2018 at 23:05, Richard Henderson wrote: > On 04/10/2018 12:07 AM, Peter Maydell wrote: >> In particular the dash shell >> would segfault if the frame wasn't as big enough. > > Ah, that was the critical difference in my failure to replicate -- the fedora > sysroot

Re: [Qemu-devel] [PATCH for-2.12] linux-user/signal.c: Ensure AArch64 signal frame isn't too small

2018-04-09 Thread Richard Henderson
On 04/10/2018 12:07 AM, Peter Maydell wrote: > In particular the dash shell > would segfault if the frame wasn't as big enough. Ah, that was the critical difference in my failure to replicate -- the fedora sysroot doesn't have dash. As you say, the patch matches the kernel so, Reviewed-by:

Re: [Qemu-devel] [PATCH for-2.12] linux-user/signal.c: Ensure AArch64 signal frame isn't too small

2018-04-09 Thread Laurent Vivier
Le 09/04/2018 à 16:07, Peter Maydell a écrit : > The AArch64 signal frame design was extended for SVE in commit > 8c5931de0ac77388096d79ceb, so that instead of having a fixed setup we > now add various records to the frame, with some of them possibly > overflowing into an extra space outside the

[Qemu-devel] [PATCH for-2.12] linux-user/signal.c: Ensure AArch64 signal frame isn't too small

2018-04-09 Thread Peter Maydell
The AArch64 signal frame design was extended for SVE in commit 8c5931de0ac77388096d79ceb, so that instead of having a fixed setup we now add various records to the frame, with some of them possibly overflowing into an extra space outside the original 4K reserved block in the target_sigcontext.